Refactor test-contains-value?-map

phel-lang · Oct 24, 2022 · ed0bf96 · ed0bf96
1 parent 8425cfb
commit ed0bf96
Showing 1 changed file with 9 additions and 7 deletions.
diff --git a/tests/phel/test/core/boolean-operation.phel b/tests/phel/test/core/boolean-operation.phel
@@ -189,23 +189,25 @@
 
 (deftest test-contains-value?-list
   (is (false? (contains-value? '() 1)))
-  (is (false? (contains-value? '(1) 2)))
+  (is (false? (contains-value? '(1) 0)))
   (is (true? (contains-value? '(1) 1))))
 
 (deftest test-contains-value?-vector
   (is (false? (contains-value? [] 1)))
-  (is (false? (contains-value? [1] 2)))
+  (is (false? (contains-value? [1] 0)))
   (is (true? (contains-value? [1] 1))))
 
 (deftest test-contains-value?-set
   (is (false? (contains-value? (set) 1)))
-  (is (false? (contains-value? (set 1) 2)))
+  (is (false? (contains-value? (set 1) 0)))
   (is (true? (contains-value? (set 1) 1))))
 
-(deftest test-contains-value?-hash-map
-  (is (false? (contains-value? {} 1)))
-  (is (false? (contains-value? {:a 1} 2)))
-  (is (true? (contains-value? {:a 1} 1))))
+(deftest test-contains-value?-map
+  (let [full-name {:first-name "Marco" :last-name "Polo" :street nil}]
+    (is (true? (contains-value? full-name "Marco")))
+    (is (true? (contains-value? full-name "Polo")))
+    (is (false? (contains-value? full-name "Street")))
+    (is (false? (contains-value? full-name "Unknown")))))
 
 (deftest test-compare
   (is (= -1 (compare 1 2)) "(compare 1 2)")