Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create CommandFacade and use it as entry point instead of CommandFactory #326

Merged
merged 1 commit into from Aug 12, 2021
Merged

Create CommandFacade and use it as entry point instead of CommandFactory #326

merged 1 commit into from Aug 12, 2021

Conversation

Chemaclass
Copy link
Member

馃摎 Description

The Command module doesn't have a Facade, so we are using the Factory directly in the phel script
(and in the integration tests).

馃敄 Changes

  • Add CommandFacade to make clear what are the entry points from the Command module.

@Chemaclass Chemaclass added the refactoring Refactoring or cleaning related label Aug 12, 2021
@Chemaclass Chemaclass self-assigned this Aug 12, 2021
@jenshaase
Copy link
Member

Looks good. Thanks.

@jenshaase jenshaase merged commit 013b332 into master Aug 12, 2021
@JesusValera JesusValera deleted the refactor/create-command-facade branch August 12, 2021 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jenshaase jenshaase jenshaase approved these changes

@JesusValera JesusValera JesusValera approved these changes

Assignees

@Chemaclass Chemaclass

Labels
refactoring Refactoring or cleaning related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Chemaclass @jenshaase @JesusValera