Add new layout. #37
Open
Add new layout. #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…the same dimensions. It is slow due to the second additional loop. TODO: speed up the slow loop.
phenax
requested changes
Jun 11, 2022
There was a problem hiding this comment.
Sorry for the delay. A couple of issues here -
- The size of the secondary main is pretty inconsistent and keeps changing since it doesn't have a fixed size set here
- As you mentioned, it can get a bit slow with a lot of nodes (I'll go through this a bit later)
- The name
ntallmakes it seem like we can havennumber of nodes as master which doesn't seem to be the case here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is similar to the tall layout but the first stack node keeps the same dimensions. It is slow due to the second additional loop. I'll appreciate some help or hints so I can improve this layout.