Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove bc from the dependencies #71

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

amtoine
Copy link
Collaborator

@amtoine amtoine commented Feb 12, 2023

Should close #70.

As bc is not used anywhere in the code, this PR removes it from the dependencies of bsp-layout.

before the PR

bc is only used in the dependency checks but never as an actual command call

> rg -w bc
install.sh:for dep in bc bspc bash man; do
README.md:* `bc`
src/utils/common.sh:  for dep in bc bspc man; do

after the PR

rg -w bc is empty 馃憣

@amtoine amtoine added the bug Something isn't working label Feb 12, 2023
@amtoine amtoine requested a review from phenax February 12, 2023 10:39
@amtoine amtoine self-assigned this Feb 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unnecessary dependencies
1 participant