Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read env to change the CSR signer name #76

Merged
merged 2 commits into from
Aug 22, 2022

Conversation

jchanam
Copy link
Contributor

@jchanam jchanam commented Aug 19, 2022

What type of PR is this?
/kind feature

What this PR does / why we need it:
As stated on the README, on EKS 1.22 it's needed to use the certificate signer beta.eks.amazonaws.com/app-serving.

The issue is that with the current code, the only way to do it is changing it, creating a new and custom docker image, and use it with the new signer.

This PR adds a new environmental variable that allows to define this signer to the one the user wants, with the default value that it's currently being used (kubernetes.io/kubelet-serving), so no breaking changes are introduced.

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

New env `IMAGESWAP_CSR_SIGNER_NAME` added, allowing to define what signer to use on the Certificate Signing Request.

Additional documentation e.g., usage docs, etc.:

On the current deploy files, a new element should be added to the 'imageswap-env' configmap, resulting in:

kind: ConfigMap
apiVersion: v1
metadata:
  name: imageswap-env
  namespace: imageswap-system
  labels:
    app: imageswap
    resource: configmap
data:
  FLASK_ENV: "production"
  PYTHONUNBUFFERED: "TRUE"
  IMAGESWAP_MODE: "MAPS"
  IMAGESWAP_LOG_LEVEL: "INFO"
  IMAGESWAP_CSR_SIGNER_NAME: "beta.eks.amazonaws.com/app-serving"

Copy link
Owner

@phenixblue phenixblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for the most part, just a simple docs update and we should be good to go.

README.md Outdated Show resolved Hide resolved
Copy link
Owner

@phenixblue phenixblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@phenixblue phenixblue merged commit 1254e76 into phenixblue:master Aug 22, 2022
@jchanam jchanam deleted the allow-defining-signer-name branch August 22, 2022 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants