Read env to change the CSR signer name #76
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
As stated on the README, on EKS 1.22 it's needed to use the certificate signer
beta.eks.amazonaws.com/app-serving
.The issue is that with the current code, the only way to do it is changing it, creating a new and custom docker image, and use it with the new signer.
This PR adds a new environmental variable that allows to define this signer to the one the user wants, with the default value that it's currently being used (
kubernetes.io/kubelet-serving
), so no breaking changes are introduced.Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Additional documentation e.g., usage docs, etc.: