Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introducing [REPLACE] #85

Merged
merged 1 commit into from
Oct 5, 2022
Merged

Introducing [REPLACE] #85

merged 1 commit into from
Oct 5, 2022

Conversation

M4C4R
Copy link
Contributor

@M4C4R M4C4R commented Sep 27, 2022

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:

/kind bug
/kind cleanup
/kind deprecation
/kind design
/kind documentation

/kind feature

/kind release

What this PR does / why we need it:

Introduces further flexibility to the MAPS swapping method.

Which issue(s) this PR fixes:

Fixes #84

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

New reserved keyword [REPLACE] which allows for full image path replacement using patterns.

Additional documentation e.g., usage docs, etc.:

Updated README.md

Copy link
Owner

@phenixblue phenixblue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this.

/lgtm

Comment on lines +246 to +247
if key.startswith(imageswap_exact_keyword):
key = key[len(imageswap_exact_keyword) :].lstrip()
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this. Great update!

@phenixblue phenixblue merged commit 819b60d into phenixblue:master Oct 5, 2022
@phenixblue
Copy link
Owner

@M4C4R I have some things in my personal life that are taking up a lot of my time I normally use to maintain this project. Your changes have been merged, but I may be a little slow to cut a new release. Please bare with me.

@M4C4R
Copy link
Contributor Author

M4C4R commented Oct 5, 2022

@phenixblue no worries, thanks for merging :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to remove org/project during swap - MAPS
2 participants