Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use iframe srcdoc instead of src #55

Closed
cblavier opened this issue Sep 2, 2022 · 0 comments · Fixed by #382
Closed

Use iframe srcdoc instead of src #55

cblavier opened this issue Sep 2, 2022 · 0 comments · Fixed by #382
Assignees
@cblavier
Labels
enhancement New feature or request

Comments

@cblavier
Copy link
Contributor

cblavier commented Sep 2, 2022

We are currently using src when using (optional) iframe rendering.
This triggers one additional HTTP request for every story rendered (1 story = 1 iframe = 1 HTTP GET)

We could instead use iframe srcdoc which allows inline rendering.
@cblavier cblavier added the enhancement New feature or request label Sep 2, 2022
@cblavier cblavier changed the title Use IFrame srcdoc instead of src Use iframe srcdoc instead of src Sep 2, 2022
@cblavier cblavier self-assigned this Sep 8, 2022
@cblavier cblavier mentioned this issue Oct 31, 2023
Merged
@cblavier cblavier linked a pull request Oct 31, 2023 that will close this issue
Using iframe srcdoc when possible #382
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cblavier cblavier

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Using iframe srcdoc when possible phenixdigital/phoenix_storybook
1 participant
@cblavier