Using iframe srcdoc when possible #382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [floki](https://github.com/philss/floki) from 0.35.0 to 0.35.1. - [Release notes](https://github.com/philss/floki/releases) - [Changelog](https://github.com/philss/floki/blob/main/CHANGELOG.md) - [Commits](philss/floki@v0.35.0...v0.35.1) --- updated-dependencies: - dependency-name: floki dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [dialyxir](https://github.com/jeremyjh/dialyxir) from 1.4.1 to 1.4.2. - [Release notes](https://github.com/jeremyjh/dialyxir/releases) - [Changelog](https://github.com/jeremyjh/dialyxir/blob/master/CHANGELOG.md) - [Commits](jeremyjh/dialyxir@1.4.1...1.4.2) --- updated-dependencies: - dependency-name: dialyxir dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [ex_doc](https://github.com/elixir-lang/ex_doc) from 0.30.7 to 0.30.9. - [Changelog](https://github.com/elixir-lang/ex_doc/blob/main/CHANGELOG.md) - [Commits](elixir-lang/ex_doc@v0.30.7...v0.30.9) --- updated-dependencies: - dependency-name: ex_doc dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [floki](https://github.com/philss/floki) from 0.35.1 to 0.35.2. - [Release notes](https://github.com/philss/floki/releases) - [Changelog](https://github.com/philss/floki/blob/main/CHANGELOG.md) - [Commits](philss/floki@v0.35.1...v0.35.2) --- updated-dependencies: - dependency-name: floki dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [phoenix_view](https://github.com/phoenixframework/phoenix_view) from 2.0.2 to 2.0.3. - [Changelog](https://github.com/phoenixframework/phoenix_view/blob/v2.0.3/CHANGELOG.md) - [Commits](phoenixframework/phoenix_view@v2.0.2...v2.0.3) --- updated-dependencies: - dependency-name: phoenix_view dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [tailwindcss](https://github.com/tailwindlabs/tailwindcss) from 3.3.3 to 3.3.5. - [Release notes](https://github.com/tailwindlabs/tailwindcss/releases) - [Changelog](https://github.com/tailwindlabs/tailwindcss/blob/master/CHANGELOG.md) - [Commits](tailwindlabs/tailwindcss@v3.3.3...v3.3.5) --- updated-dependencies: - dependency-name: tailwindcss dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [esbuild](https://github.com/evanw/esbuild) from 0.19.4 to 0.19.5. - [Release notes](https://github.com/evanw/esbuild/releases) - [Changelog](https://github.com/evanw/esbuild/blob/main/CHANGELOG.md) - [Commits](evanw/esbuild@v0.19.4...v0.19.5) --- updated-dependencies: - dependency-name: esbuild dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #382 +/- ##
==========================================
- Coverage 96.41% 96.32% -0.10%
==========================================
Files 38 38
Lines 1980 2012 +32
==========================================
+ Hits 1909 1938 +29
- Misses 71 74 +3
☔ View full report in Codecov by Sentry. |
cblavier
force-pushed
the
55-use-iframe-srcdoc-instead-of-src
branch
from
be30d8e
to
3bb4ade
Compare
cblavier
force-pushed
the
55-use-iframe-srcdoc-instead-of-src
branch
from
3bb4ade
to
52c9d38
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For dead components, it's possible to inline iframe content directly in the iframe srcdoc attribute, which prevents extra HTTP request for each iframe (for a component story with 10 variations, a classic iframe would trigger 10 HTTP requests on
/live/iframe/*story/Unfortunately, this strategy can't apply to live components that are stateful, and require a full liveview behind to update their state.
Closes #55