Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor changes to installation instructions #215

Merged
merged 2 commits into from
Mar 26, 2024
Merged

Conversation

fnattino
Copy link
Contributor

Hopefully making the installation of R dependencies more robust.

@@ -35,6 +35,8 @@ curl -o environment.yml https://raw.githubusercontent.com/phenology/springtime/m
mamba env update -n springtime -f environment.yml
```

Note that some of the R dependencies are not available as pre-compiled binaries for some operating systems and architectures. If the command above fails, follow [the step below](#install-r-dependencies) to build the R dependencies on your system.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that the conda environment is also not complete. Even if you use this, you still need to run the R install instructions from below. However, without pre-installing most (indirect) dependencies, this takes ages.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, I wanted to stress the fact that even if this fails (like on OS X with Intel processor, for which r-BayesialTools is not available), you could still go ahead and compile the binaries in the following step. But I have tried to make this more explicit, do you think it is clearer now?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes! I agree the clarification was needed/helpful. My only concern was that the previous formulation seemed to suggest that the next steps weren't necessary if this step worked. The new text is much better, thanks

@fnattino fnattino merged commit b749ea0 into main Mar 26, 2024
4 checks passed
@fnattino fnattino deleted the fix-install-r-deps branch March 26, 2024 08:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants