Fix loading of Daymet point data #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I can confirm this fixes the issue. Would be good to find the source of this change. Doesn't seem to come from daymetr https://github.com/bluegreen-labs/daymetr/commits/master/ |
Peter9192
approved these changes
Mar 28, 2024
|
Perhaps we could add your example from #222 as a test case, so we keep an eye on future changes |
|
Added a test to check whether the downloaded CSV files are parsed properly. |
fnattino
commented
Apr 8, 2024
| @@ -254,6 +254,7 @@ def download(self): | |||
| def download_point(self, point: Point): | |||
| """Download data for a single point.""" | |||
| path = self._point_path(point) | |||
| path.parent.mkdir(exist_ok=True, parents=True) | |||
There was a problem hiding this comment.
In order to get the test to work, I had to fix also #221
Peter9192
approved these changes
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #222