Add PyPI publishing workflow #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fnattino
approved these changes
Apr 26, 2024
There was a problem hiding this comment.
Hi @Peter9192 , thanks a lot for taking care of this. Just one probably not-so-relevant comment below, feel free to merge on my side!
|
|
||
| on: | ||
| release: | ||
| types: [created] |
There was a problem hiding this comment.
In the workflow I have used, I have "published" here instead of "created".
I am not sure which one is safer to use, here someone suggests that releases that are automatically generated might go directly to the "published" state without passing through the "created" one (thus "published" should be better suited here). However this is probably some sort of edge case, so feel free to leave or modify as you see fit!
There was a problem hiding this comment.
Thanks for the suggestion, I adopted it :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add automated publishing to PyPI upon release.
PyPI is made a "trusted publisher", so we don't need to store any secret tokens.
Instructions: https://packaging.python.org/en/latest/guides/publishing-package-distribution-releases-using-github-actions-ci-cd-workflows/
Copied from WAM2layers/WAM2layers#342