Skip to content
This repository has been archived by the owner on Mar 12, 2020. It is now read-only.

[RFC] Logging of API output should be disabled, or made configurable #3

Open
Renegade334 opened this issue May 20, 2015 · 1 comment

Comments

@Renegade334
Copy link
Contributor

The inclusion of $logger->info('resolve', array('url' => $url, 'json' => $json)) in the resolve callback results in kilobytes of clutter being dumped to the debug output every time a YouTube video is looked up. Unless the user is actively debugging the plugin, there's no need to dump all this output.

Personally, I'd prefer a simple debug message along the lines of YouTube API data received {"id":"VIDEOID"}. Would be interested to know what others think.

@elazar
Copy link
Member

elazar commented May 20, 2015

I think this sounds reasonable. Maybe add a 'debug' flag to configuration that, when set to true, dumps the current output, else it dumps output in the format you've suggested for simpler debugging?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants