-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
VO reads out other aspects of sim when pressing home/end on a slider #164
Comments
So according to https://webaim.org/articles/voiceover/ these keys should jump the virtual cursor to the top/end of the page.
It is just weird that it still does this while focus is on a slider. I am going to see if it happens on a random HTMl slider. |
This is not happening in example sliders I am finding around the Web, so this might be something we need to fix. |
I thought maybe an event.preventDefault might be causing this, but I removed the one in AccessibleValueHandler and it had no impact on this behavior. |
I think I found it, it seems to be because of the <h1>My heading</h1>
<p>My slider:</p>
<input type="range" min="1" max="10">
<button>My Button</button> But for this markup, pressing Home/End on a Mac changes the slider value AND moves the virtual cursor to the start/end of the article. <article>
<h1>My heading</h1>
<p>My slider:</p>
<input type="range" min="1" max="10">
<button>My Button</button>
</article> @terracoda assigning to you to review the behavior from this markup. Is there anything you would like to do, or should we just document and move on? |
I think @zepumph and I once had a similar issue with sliders inside a list. It was in GFL or GFLB. Would we no longer have a parent container? or would we need to use a different element, like a div? |
I can't seem to reproduce this, but I am not running the latest MacOS. What sim is causing the issue? |
Correct.
I was able to see this with macOS 11.2 in all sims that use a slider (OL, GFL, JT, others).
Exactly, one way to fix this could be to replace the |
@jessegreenberg, I did a little reading on the First, I do think it is worth submitting a bug report to Apple because we are using the element correctly and VO is not handling it properly with regards to sliders. For
Since our sims screen can be used individually, though I am not sure the Home screen fits that category, it seems to make sense to use an For
The tutorial plain language definition for
I think it is logical to think of a sim screen as a thematic grouping or a chapter-like thing. I still think the According to the spec a Suggested action: If a response doesn't come and/or you don't think a response is forthcoming, do you see any issue replacing the sim screen Articles I read on the subject:
|
Sounds good @terracoda. I submitted a bug report to apple about this. Unfortunately, they have responded to zero of the ten bug reports we have submitted so I think it is unlikely that we will get a response. That being said, I am OK leaving as |
I am experiencing this issue with Big Sur, and I am also finding that using the function and arrow shortcut keys for Home and End can move focus. In GFLB, it only seems to happen with function right arrow, which moves the slider to max or End. |
@jessegreenberg, I'll open a new issue just in case. |
Yes based on what you described it sounds like this is still an issue with macOS VoiceOver. We submitted a bug report to Apple about this, but I haven't heard back yet. In #164 (comment) we found a potential workaround where removing |
Before this issue also involved focus changes? I think we might want to consider removing section elements. But to fix all sims, ti would mean maintenance releases for all our sims with Interactive Description, right? |
Just to be clear, what exactly is the fix? |
Oh , I see - no you are correct, it was just the virtual cursor before but focus remained on the slider. Sorry, I meant to say |
Hmm, I think our current structure is actually correct and Apple has messed things up with the Article element. That said, I think it is perfectly legal to nest section elements. @jessegreenberg, could you test if changing the a11y-root And, did your previous test include changing the a11y-root There might be one other thing to try, and that is to add the the explicit |
Totally agree!
Sure, Ill try this out.
Yes, I believe that is the only thing we tested so far. |
Would a fix for this issue impact this issue |
Every sim with interactive description that has a slider, suffers from this Apple-induced bug when VoiceOver is enabled. It is a bad experience. We may need to reconsider using a work around and doing maintenance releases on sims with sliders:
|
Found during phetsims/qa#614 on several sims on MacOS 11 on Safari with VO. Also seen on published.
If you use home or end on a slider, it is meant to jump to the ends of the slider. On a Mac this involves the fn key. When you use this to jump to the ends of the slider the "reset all button" or the start of the sim will start being read before going back to what happened to the slider.
From slack:
The text was updated successfully, but these errors were encountered: