Code Review ClippableFace

[marlitas]

This issue will track review comments and questions for ClippableFace.

[marlitas]

• I am unclear what a "fake" corner is... Is this the point that is chosen along a line that another point is moved to that you were talking about? If so, I think more documentation is needed to properly set that concept up.

The fakeCornerY is used to determine the "fake" corner that is used for unsorted-edge clipping.

• What does "inspecting the edges" mean?
  Converts the face to an edged-clipped face (inspecting the edges)

• I think I vaguely understand what an accumulator is (creating a clippableFace from a variety of edges ), but I am not sure in the different between a ScratchAccumulator and Accumulator here...

/**
   * Returns a singleton accumulator for this type of face.
   */
  getScratchAccumulator(): ClippableFaceAccumulator;

  /**
   * Returns a new accumulator for this type of face.
   */
  getAccumulator(): ClippableFaceAccumulator;

• What is a new-polygon?

[jonathanolson]

Added documentation about fake corners in e080868.

[jonathanolson]

Added documentation to the places noted (since those seem stable enough to deserve the documentation)