Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PropertyIO is declared in ReadOnlyProperty #429

Open
samreid opened this issue Feb 15, 2023 · 0 comments
Open

PropertyIO is declared in ReadOnlyProperty #429

samreid opened this issue Feb 15, 2023 · 0 comments

Comments

@samreid
Copy link
Member

samreid commented Feb 15, 2023

As @pixelzoom described in phetsims/tandem#285 (comment)

(1) PropertyIO is not defined in Property.ts, and is in fact associated with core type ReadOnlyProperty. So it violates the PhET naming conventions, and was therefore confusing. If conventions had been followed, I should have been looking at replacements of Property.PropertyIO with PropertyIO.

At the moment PhET-iO does not distinguish between PropertyIO and ReadOnlyPropertyIO. Instead, everything is PropertyIO and non-settable ones are identified via phetioReadOnly: true. I do not know whether this is the clearest, best strategy, but just wanted to write down how it works at the moment. How can we decide whether we need to create ReadOnlyPropertyIO and reveal it to clients?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant