-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Investigate removal of a couple es translations #24
Comments
Looks like in CAV 1.1, the translations were coming from soccer common: phetsims/soccer-common@75c9aee |
…el#24 Signed-off-by: Michael Kauzmann <michael.kauzmann@colorado.edu>
In ESP and Number Line: Integers looks like the bug has come from changing the joist strings. This is what they are expecting:
Broke on 3/14/24: phetsims/joist@700195e |
…lations, phetsims/babel#24 Signed-off-by: Michael Kauzmann <michael.kauzmann@colorado.edu>
…lations, phetsims/babel#24 Signed-off-by: Michael Kauzmann <michael.kauzmann@colorado.edu>
…lations, #24 Signed-off-by: Michael Kauzmann <michael.kauzmann@colorado.edu>
…lations, phetsims/babel#24 Signed-off-by: Michael Kauzmann <michael.kauzmann@colorado.edu>
I think I'd like to create a script that looks at all the string keys needed in a sim and ensures they all live on the main still (for common code only). I'll see how that goes. (good luck me). |
Thanks for the report. I believe nothing more is needed here, and everything will proceed from phetsims/chipper#1446, as well as the language title and description over in phetsims/joist#976. Closing |
Signed-off-by: Michael Kauzmann <michael.kauzmann@colorado.edu>
…el#24 Signed-off-by: Michael Kauzmann <michael.kauzmann@colorado.edu>
Signed-off-by: Michael Kauzmann <michael.kauzmann@colorado.edu>
In phetsims/qa#1098 (comment), QA found that there was a translator that removed a few spanish strings from preferences. This occurred in ffb1a52. I believe this was a mistake done by a translator, but I don't know how to proceed, since I know we don't do too much translation moderation. I think it may just be good to check in with @DianaTavares, and see if she wants to do a quick translation to add these region and culture strings back in for
es
. Note that still on main, there are no region and culture strings translated fores
, and I don't know if there is context I'm missing, or if this is purposeful. My guess is that it isn't purposeful.@DianaTavares, let me know if you want to discuss async.
The text was updated successfully, but these errors were encountered: