Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate removal of a couple es translations #24

Closed
zepumph opened this issue Jul 2, 2024 · 5 comments
Closed

Investigate removal of a couple es translations #24

zepumph opened this issue Jul 2, 2024 · 5 comments
Assignees

Comments

@zepumph
Copy link
Member

zepumph commented Jul 2, 2024

In phetsims/qa#1098 (comment), QA found that there was a translator that removed a few spanish strings from preferences. This occurred in ffb1a52. I believe this was a mistake done by a translator, but I don't know how to proceed, since I know we don't do too much translation moderation. I think it may just be good to check in with @DianaTavares, and see if she wants to do a quick translation to add these region and culture strings back in for es. Note that still on main, there are no region and culture strings translated for es, and I don't know if there is context I'm missing, or if this is purposeful. My guess is that it isn't purposeful.

@DianaTavares, let me know if you want to discuss async.

@zepumph
Copy link
Member Author

zepumph commented Jul 2, 2024

Looks like in CAV 1.1, the translations were coming from soccer common: phetsims/soccer-common@75c9aee

zepumph added a commit to phetsims/soccer-common that referenced this issue Jul 2, 2024
…el#24

Signed-off-by: Michael Kauzmann <michael.kauzmann@colorado.edu>
@zepumph
Copy link
Member Author

zepumph commented Jul 2, 2024

In ESP and Number Line: Integers looks like the bug has come from changing the joist strings. This is what they are expecting:

 "JOIST/preferences.tabs.localization.regionAndCulture.portrayalSets.africa": "‪Africa‬",
    "JOIST/preferences.tabs.localization.regionAndCulture.portrayalSets.africaModest": "‪Africa (Modest)‬",
    "JOIST/preferences.tabs.localization.regionAndCulture.portrayalSets.asia": "‪Asia‬",
    "JOIST/preferences.tabs.localization.regionAndCulture.portrayalSets.latinAmerica": "‪Latin America‬",
    "JOIST/preferences.tabs.localization.regionAndCulture.portrayalSets.oceania": "‪Oceania‬",
    "JOIST/preferences.tabs.localization.regionAndCulture.portrayalSets.unitedStatesOfAmerica": "‪United States of America‬",

Broke on 3/14/24: phetsims/joist@700195e

zepumph added a commit to phetsims/joist that referenced this issue Jul 2, 2024
…lations, phetsims/babel#24

Signed-off-by: Michael Kauzmann <michael.kauzmann@colorado.edu>
zepumph added a commit to phetsims/chipper that referenced this issue Jul 2, 2024
…lations, phetsims/babel#24

Signed-off-by: Michael Kauzmann <michael.kauzmann@colorado.edu>
zepumph added a commit that referenced this issue Jul 2, 2024
…lations, #24

Signed-off-by: Michael Kauzmann <michael.kauzmann@colorado.edu>
zepumph added a commit to phetsims/soccer-common that referenced this issue Jul 2, 2024
…lations, phetsims/babel#24

Signed-off-by: Michael Kauzmann <michael.kauzmann@colorado.edu>
@zepumph
Copy link
Member Author

zepumph commented Jul 2, 2024

I think I'd like to create a script that looks at all the string keys needed in a sim and ensures they all live on the main still (for common code only). I'll see how that goes. (good luck me).

@DianaTavares
Copy link

CM share this list of sims that have region and culture:
screenshot_3393_480

I review if those sims also have this problem:
Area Model Algebra: it is ok!
Area Model multiplication: it is ok!
balancing-act: it is ok with those strings, but indicating that is not 100%, but al strings are translated.
energy-skate.park-basics: I don't know why it is on the list, it doesn't have region and culture, same for F&M:B
Graphing-lines: : it is ok!
Graphing-slope-intersept: it is ok!
both number line: it is ok!

@zepumph
Copy link
Member Author

zepumph commented Jul 2, 2024

Thanks for the report. I believe nothing more is needed here, and everything will proceed from phetsims/chipper#1446, as well as the language title and description over in phetsims/joist#976. Closing

@zepumph zepumph closed this as completed Jul 2, 2024
zepumph added a commit to phetsims/joist that referenced this issue Jul 2, 2024
Signed-off-by: Michael Kauzmann <michael.kauzmann@colorado.edu>
zepumph added a commit to phetsims/joist that referenced this issue Jul 3, 2024
…el#24

Signed-off-by: Michael Kauzmann <michael.kauzmann@colorado.edu>
zepumph added a commit that referenced this issue Jul 3, 2024
Signed-off-by: Michael Kauzmann <michael.kauzmann@colorado.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants