-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Balloon grab/drag interaction to support mobile accessibility #452
Comments
Grab BASE's Balloons:
Touch Interaction
EDIT - We eventually decided on "movable" instead of "draggable" for the custom grab and drag. |
@zepumph, please implement the option 1's for now. |
Context Responses for Keyboard (samples):
Context Responses for Touch (samples):
|
@zepumph, and I'm not hearing the word "Released" in the release interaction of the current version of BASE. |
Tagging @jessegreenberg in case he needs to know about these descriptions. |
@zepumph, please re-assign if you have questions. |
@zepumph, reposting your generalized code here from phetsims/scenery-phet#536 (comment)
I'll try to rework descriptions from #452 (comment) to remain consistent with and true to the general pattern that you have already implemented and that we likely discussed previously. Changes coming in next post. |
Grab BASE's Balloons:
Touch Interaction
|
I took a quick look, looks good to me! But let me know if I can be of more help! |
All has been implemented except for #452 (comment). @jessegreenberg I would like to hand it over to you, because it is your sim, and I want to leave it up to you how to implement those changes. Also they seem like they are not totally necessary for fast approaching interviews (though I'll leave that decision up to you). |
Just noting here with keyboard and screen reader the changes sound good: Once I have dev link, I will test touch and screen reader on my phone. |
@zepumph, I tested balloons-and-static-electricity/1.5.0-dev.12 on my iPhone 7 (iOS 13.1.3) I hear "Yellow Balloon, movable" on focus. I swipe to read the help text and get the correct help text, "Double tap and hold to drag balloon. Lift to release." That said, the interaction is working, though there are delays and pile-ups of alerts during grabbing, dragging and releasing that we will want to look at more deeply. Nice work @zepumph. With a touch-platform-specific "initial grab" response, I think the implementation will be quite usable for Jen's interviews next week (edited). Issues to note, and maybe to move to a new issue
|
Re #452 (comment), I think it would be best if jesse took it from here with his sim. |
@jessegreenberg, regarding my comment about the not hearing "Released" #452 (comment), I think in several cases the initial release may be getting over-written by follow-up responses (alerts). I hear "Released." when I move the balloon far enough away from the sweater. No need to investigate. I think to make "Released" heard more often would require a design change, perhaps changing "Released." from a stand-alone-response to a parameter to be inserted at the start of the first directional response (alert). We can investigate this in a separate issue for a maintenance release when there is time. |
Sounds good @terracoda, I am also generally not hearing any alerts when the balloon is grabbed or released on iOS VoiceOver. |
@terracoda do you think it would be helpful to make the on demand help text for the draggable with touch read automatically with aria-describedby? |
In meeting today we decided to add aria-describedby. |
@terracoda here is a version with these changes, can you please review? Also, please see comments in phetsims/scenery-phet#536 (comment) as discoveries there changed the implementation a little from what we discussed this morning. FInally, #455 is still an issue. But the interaction and alert content is all there. |
@jessegreenberg, the In a complex 2-balloon situation, I heard "Press Space to release" at some point. Could you check if there are some special instances in 2-balloon experiments where we might have some keyboard-specific strings possibly showing up? |
Regarding "Press space to release". I think there is a hint to release after a long drag interaction. That is only needed fro keyboard because there is a grabbed mode. I don't think we need it for mobile interaction. |
@jessegreenberg, also, I am hearing the hint "Double tap and hold. Lift finger to release" 3 times upon getting focus on a balloon. |
Re #452 (comment), I actually hear the hint 3 times on the Green balloon and 2 times on the Yellow balloon. |
@jessegreenberg, I reviewed version in #452 (comment) and made 2 new issues. Hope that's ok. FYI, I did see pink highlights while activating other controls besides the balloons, but none of the highlights seemed to get in the way nor make me think my focus was in the wrong place. |
@jessegreenberg, assigning back to you as I am not sure what to do with this issue. |
Platform
General
On focus I here the following (which I think is all correct):
Interaction
Reading the pdom content
|
Not sure what label is needed, but want to make sure this issue is fully wrapped up before publication with sound, assuming the goal is to publish with mobile a11y as well. Not 100% sure that publishing with mobile-a11y is in fact a goal. |
This work has been deferred again, and mobile accessibility will not be supported in the upcoming publication of BASE. |
From phetsims/scenery-phet#536 (comment), we will likely need to do a few updates to get this sim to support mobile accessibility (like iOS and VO).
@terracoda please supply the appropriate help texts, one for keyboard (likely the same as it currently is), and one for touch, and I can add these in conditionally for mobile devices.
The text was updated successfully, but these errors were encountered: