Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom mass/volume range should always be the full range of the NumberControl? #115

Closed
zepumph opened this issue Mar 5, 2024 · 3 comments
Assignees

Comments

@zepumph
Copy link
Member

zepumph commented Mar 5, 2024

From #31, we found that the max custom mass is set to 100, but that seems arbitrary, and like it shouldn't hard coded. Instead, why not always have it be the full range of the number control?

@zepumph
Copy link
Member Author

zepumph commented Mar 6, 2024

Over in #31 (comment) @DianaTavares confirmed that this is the right behavior to implement.

@zepumph
Copy link
Member Author

zepumph commented Mar 6, 2024

In density, we kept the mas for custom to match the max of the density readout. So that seems like a reasonable constraint there.

@zepumph
Copy link
Member Author

zepumph commented Mar 6, 2024

I discussed with @DianaTavares and got all the custom ranges sorted out. Another issue may be necessary to fix how the custom material selector works for the bottle screen, since it is more important there for it to maintain the same density as the volume changes. @DianaTavares will make that issue if it is needed. Thanks!

@zepumph zepumph closed this as completed Mar 6, 2024
zepumph added a commit to phetsims/density-buoyancy-common that referenced this issue Mar 6, 2024
Signed-off-by: Michael Kauzmann <michael.kauzmann@colorado.edu>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant