Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

% submerged algorithm doesn't work in 0 gravity #124

Closed
zepumph opened this issue Mar 20, 2024 · 5 comments
Closed

% submerged algorithm doesn't work in 0 gravity #124

zepumph opened this issue Mar 20, 2024 · 5 comments

Comments

@zepumph
Copy link
Member

zepumph commented Mar 20, 2024

From #112, we are calculating percent submerged based on buoyancy force. This force is determined by gravity, so we don't have a way to get the submerged percentage when gravity is 0. Also this was causing #123.

@DianaTavares
Copy link

It is not necessary that the minimal value of gravity to be zero. That doesn't support the learning goals. It can be 0.1 m/s2. If that solves the issue, good!! Or it can be bigger if it is necessary because the learning goal of that controls is small.

@zepumph
Copy link
Member Author

zepumph commented Mar 20, 2024

I really like having a min gravity of 0.1. @AgustinVallejo want to update that and remove our workaround?

@AgustinVallejo
Copy link
Contributor

I can! Really easy. However I have mixed feelings, since it's really interesting to show that at g=0 buoyant force does not apply, thus it being a direct consequence of water's weight, so I don't know how to feel about removing that feature. Obviously it would solve all our code problems in one sweep, but at what cost? I will apply the fix and propose to discuss this at design meeting, even if it means more work for us.

@AgustinVallejo AgustinVallejo removed their assignment Mar 20, 2024
zepumph added a commit to phetsims/density-buoyancy-common that referenced this issue Mar 20, 2024
@DianaTavares
Copy link

I really think that is a distraction to have a g=0 m/s2. This can be discussed in a design meeting next week, but the idea of that control was that, even that g is related to the model of the buoyancy force, it is also in the weight force and in the same way! Then that doesn't modify the buoyant behavior of the block. A g=0 obviously affects the buoyancy and interaction with the block, but that goes beyond this simulation.

AgustinVallejo added a commit to phetsims/density-buoyancy-common that referenced this issue Mar 21, 2024
@AgustinVallejo
Copy link
Contributor

That sounds convincing! Let's close :)

AgustinVallejo added a commit to phetsims/density-buoyancy-common that referenced this issue Mar 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants