Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name change to 'Kick 5' button not maintained in launched sim #114

Closed
Nancy-Salpepi opened this issue Mar 29, 2022 · 4 comments
Closed

Name change to 'Kick 5' button not maintained in launched sim #114

Nancy-Salpepi opened this issue Mar 29, 2022 · 4 comments

Comments

@Nancy-Salpepi
Copy link

Test device
MacBook Air (m1 chip)

Operating System
12.3

Browser
chrome

Problem description
For phetsims/qa#789

The launched sim doesn't show any changes to the name of the 'Kick 5' button. This happens on both screens.
This issue isn't seen with the 'Kick 1' button.

Steps to reproduce

  1. In studio, go to view.kickButtonGroup.kickFiveButton.labelNode.textProperty on either screen
  2. Change the name of the button
  3. Launch sim

Visuals
Screen Shot 2022-03-29 at 10 52 18 AM

@samreid
Copy link
Member

samreid commented Mar 29, 2022

Good discovery, thanks! The button label for the Kick 5 is dynamically computed based on the number of remaining balls, so it can sometimes say "Kick 4" etc. Therefore @chrisklus and I recommend making the labels on the button non-customizable by removing their instrumentation.

@samreid
Copy link
Member

samreid commented Mar 29, 2022

Fixed as described above. @Nancy-Salpepi can you please review on phettest? Please mark for cherry-picking if all is well.

@Nancy-Salpepi
Copy link
Author

That makes total sense!
I no longer see the labelNode in the tree for either button on both screens.

@samreid
Copy link
Member

samreid commented Apr 6, 2022

@chrisklus and I confirmed this is fixed in in #122, closing.

@samreid samreid closed this as completed Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants