Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unable to open example sim #99

Closed
KatieWoe opened this issue Mar 22, 2022 · 6 comments
Closed

Unable to open example sim #99

KatieWoe opened this issue Mar 22, 2022 · 6 comments
Labels
dev:phet-io status:ready-to-cherry-pick type:bug Something isn't working
Milestone
Publish 1.0 as a ...

Comments

@KatieWoe
Copy link

Device
Dell
OS
Win 11
Browser
Chrome
Problem Description
For phetsims/qa#789
When pressing launch under the example code in the wrapper index to see the example sim, it loads only part way and the console shows the below error.
Visuals
example
@KatieWoe KatieWoe added the type:bug Something isn't working label Mar 22, 2022
@Nancy-Salpepi
Copy link

Nancy-Salpepi commented Mar 23, 2022 •
edited
Loading

I am also unable to open the HTML generated in the Studio Wrapper.

Update: I can open it today....Not sure why that happened the other day.

@chrisklus chrisklus added this to the Classroom prototype milestone Mar 28, 2022
@chrisklus chrisklus mentioned this issue Mar 28, 2022
Closed
@KatieWoe
Copy link
Author

I have been able to open HTML generated in Studio, so I'm curious about this. Let me know if I can help track it down.

@KatieWoe
Copy link
Author

I think I figured it out. If the HTML Output is Production, launching and saving work. If Output is Development then the error is seen.

@samreid samreid mentioned this issue Mar 28, 2022
Closed
samreid added a commit that referenced this issue Mar 28, 2022
@samreid
Enable validation, supply tandems, specify phetioDynamicElement: true…
6d2281b 
…, see #99 and #100
@samreid
Copy link
Member

samreid commented Mar 28, 2022

This seems fixed after the commits. @KatieWoe can you please verify on phettest? If all is well, please relabel as "ready for cherry pick".

@KatieWoe
Copy link
Author

Looks good on master

@samreid
Copy link
Member

samreid commented Apr 6, 2022

@chrisklus and I confirmed this is fixed in in #122, closing.

@samreid samreid closed this as completed Apr 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dev:phet-io status:ready-to-cherry-pick type:bug Something isn't working
Projects
None yet
Milestone
Publish 1.0 as a prototype
Development

No branches or pull requests
4 participants
@samreid @chrisklus @KatieWoe @Nancy-Salpepi