Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Array.from polyfill #817

Closed
zepumph opened this issue Nov 14, 2019 · 8 comments
Closed

Add Array.from polyfill #817

zepumph opened this issue Nov 14, 2019 · 8 comments
Assignees
@pixelzoom
Labels
priority:2-high status:blocks-publication status:ready-for-review

Comments

@zepumph
Copy link
Member

zepumph commented Nov 14, 2019

Over in phetsims/perennial#153 we are going to look into a robust polyfill, but to help unblock publication, we think that adding a specific polyfill for Array.from may be best short term.
@zepumph zepumph self-assigned this Nov 14, 2019
@zepumph
Copy link
Member Author

zepumph commented Nov 14, 2019 •
edited
Loading

Noting here that adding Array.from polyfill did fix built IE, and things are working in my local copy build.

zepumph added a commit to phetsims/phet-core that referenced this issue Nov 14, 2019
@zepumph
create phet-polyfill with Array.from in it. Add it to chipper preload…
29b79e0 
…s and to scenery.js, phetsims/chipper#817
zepumph added a commit that referenced this issue Nov 14, 2019
@zepumph
create phet-polyfill with Array.from in it. Add it to chipper preload…
577d80a 
…s and to scenery.js, #817
zepumph added a commit to phetsims/scenery that referenced this issue Nov 14, 2019
@zepumph
create phet-polyfill with Array.from in it. Add it to chipper preload…
0e5505d 
…s and to scenery.js, phetsims/chipper#817
This was referenced Nov 14, 2019
Closed
Closed
@zepumph
Copy link
Member Author

zepumph commented Nov 14, 2019

The above commit should fix this for phet builds and for scenery builds. Now I just need to commit grunt update to add the new preload.

@zepumph zepumph mentioned this issue Nov 14, 2019
Closed
zepumph added a commit to phetsims/circuit-construction-kit-black-box-study that referenced this issue Nov 14, 2019
@zepumph
grunt update to add polyfill preload, phetsims/chipper#817
72def6d
zepumph added a commit to phetsims/circuit-construction-kit-dc-virtual-lab that referenced this issue Nov 14, 2019
@zepumph
grunt update to add polyfill preload, phetsims/chipper#817
b85e5cc
zepumph added a commit to phetsims/reactants-products-and-leftovers that referenced this issue Nov 14, 2019
@zepumph
grunt update to add polyfill preload, phetsims/chipper#817
825fd63
zepumph added a commit to phetsims/equality-explorer-two-variables that referenced this issue Nov 14, 2019
@zepumph
grunt update to add polyfill preload, phetsims/chipper#817
bec33af
zepumph added a commit to phetsims/balloons-and-static-electricity that referenced this issue Nov 14, 2019
@zepumph
grunt update to add polyfill preload, phetsims/chipper#817
667eb3b
zepumph added a commit to phetsims/balancing-chemical-equations that referenced this issue Nov 14, 2019
@zepumph
grunt update to add polyfill preload, phetsims/chipper#817
a143865
zepumph added a commit to phetsims/circuit-construction-kit-dc that referenced this issue Nov 14, 2019
@zepumph
grunt update to add polyfill preload, phetsims/chipper#817
dc748fc
zepumph added a commit to phetsims/circuit-construction-kit-ac that referenced this issue Nov 14, 2019
@zepumph
grunt update to add polyfill preload, phetsims/chipper#817
930e683
zepumph added a commit to phetsims/models-of-the-hydrogen-atom that referenced this issue Nov 14, 2019
@zepumph
grunt update to add polyfill preload, phetsims/chipper#817
1e90f1a
zepumph added a commit to phetsims/gene-expression-essentials that referenced this issue Nov 14, 2019
@zepumph
grunt update to add polyfill preload, phetsims/chipper#817
cf4b817
zepumph added a commit to phetsims/vector-addition-equations that referenced this issue Nov 14, 2019
@zepumph
grunt update to add polyfill preload, phetsims/chipper#817
243befa
zepumph added a commit to phetsims/area-model-multiplication that referenced this issue Nov 14, 2019
@zepumph
grunt update to add polyfill preload, phetsims/chipper#817
70053ae
zepumph added a commit to phetsims/masses-and-springs-basics that referenced this issue Nov 14, 2019
@zepumph
grunt update to add polyfill preload, phetsims/chipper#817
fc0ce2d
zepumph added a commit to phetsims/gravity-force-lab-basics that referenced this issue Nov 14, 2019
@zepumph
grunt update to add polyfill preload, phetsims/chipper#817
cb70ae5
zepumph added a commit to phetsims/graphing-slope-intercept that referenced this issue Nov 14, 2019
@zepumph
grunt update to add polyfill preload, phetsims/chipper#817
8ca02da
zepumph added a commit to phetsims/equality-explorer-basics that referenced this issue Nov 14, 2019
@zepumph
grunt update to add polyfill preload, phetsims/chipper#817
15bfa85
zepumph added a commit to phetsims/energy-skate-park-basics that referenced this issue Nov 14, 2019
@zepumph
grunt update to add polyfill preload, phetsims/chipper#817
66e9f72
zepumph added a commit to phetsims/energy-forms-and-changes that referenced this issue Nov 14, 2019
@zepumph
grunt update to add polyfill preload, phetsims/chipper#817
00b914c
zepumph added a commit to phetsims/forces-and-motion-basics that referenced this issue Nov 14, 2019
@zepumph
grunt update to add polyfill preload, phetsims/chipper#817
ae5582c
zepumph added a commit to phetsims/sherpa that referenced this issue Nov 21, 2019
@zepumph
move array.from polyfill to sherpa, phetsims/chipper#817
d7caf4a
zepumph added a commit to phetsims/wilder that referenced this issue Nov 21, 2019
@zepumph
move array.from polyfill to sherpa, phetsims/chipper#817
6444643
zepumph added a commit to phetsims/neuron that referenced this issue Nov 21, 2019
@zepumph
move array.from polyfill to sherpa, phetsims/chipper#817
6143990
zepumph added a commit to phetsims/chains that referenced this issue Nov 21, 2019
@zepumph
move array.from polyfill to sherpa, phetsims/chipper#817
2021ab1
zepumph added a commit to phetsims/bumper that referenced this issue Nov 21, 2019
@zepumph
move array.from polyfill to sherpa, phetsims/chipper#817
54c8d0c
zepumph added a commit to phetsims/tappi that referenced this issue Nov 21, 2019
@zepumph
move array.from polyfill to sherpa, phetsims/chipper#817
2beb063
zepumph added a commit to phetsims/vegas that referenced this issue Nov 21, 2019
@zepumph
move array.from polyfill to sherpa, phetsims/chipper#817
254af7d
zepumph added a commit to phetsims/twixt that referenced this issue Nov 21, 2019
@zepumph
move array.from polyfill to sherpa, phetsims/chipper#817
6f8b307
zepumph added a commit to phetsims/joist that referenced this issue Nov 21, 2019
@zepumph
move array.from polyfill to sherpa, phetsims/chipper#817
d6d72c9
zepumph added a commit to phetsims/blast that referenced this issue Nov 21, 2019
@zepumph
move array.from polyfill to sherpa, phetsims/chipper#817
7dc5553
zepumph added a commit to phetsims/vibe that referenced this issue Nov 21, 2019
@zepumph
move array.from polyfill to sherpa, phetsims/chipper#817
ef215a6
zepumph added a commit to phetsims/axon that referenced this issue Nov 21, 2019
@zepumph
move array.from polyfill to sherpa, phetsims/chipper#817
ca88010
zepumph added a commit to phetsims/kite that referenced this issue Nov 21, 2019
@zepumph
move array.from polyfill to sherpa, phetsims/chipper#817
5fa41ae
zepumph added a commit to phetsims/sun that referenced this issue Nov 21, 2019
@zepumph
move array.from polyfill to sherpa, phetsims/chipper#817
de8f6bc
zepumph added a commit to phetsims/dot that referenced this issue Nov 21, 2019
@zepumph
move array.from polyfill to sherpa, phetsims/chipper#817
fa0ccef
zepumph added a commit to phetsims/energy-forms-and-changes that referenced this issue Nov 21, 2019
@zepumph
move array.from polyfill to sherpa, phetsims/chipper#817
b25efa1
zepumph added a commit to phetsims/gravity-and-orbits that referenced this issue Nov 21, 2019
@zepumph
move array.from polyfill to sherpa, phetsims/chipper#817
ce8f43a
zepumph added a commit to phetsims/natural-selection that referenced this issue Nov 21, 2019
@zepumph
move array.from polyfill to sherpa, phetsims/chipper#817
8ee1d4f
zepumph added a commit to phetsims/utterance-queue that referenced this issue Nov 21, 2019
@zepumph
move array.from polyfill to sherpa, phetsims/chipper#817
a9e4438
zepumph added a commit to phetsims/number-play that referenced this issue Nov 21, 2019
@zepumph
move array.from polyfill to sherpa, phetsims/chipper#817
90682dc
zepumph added a commit to phetsims/waves-intro that referenced this issue Nov 21, 2019
@zepumph
move array.from polyfill to sherpa, phetsims/chipper#817
d4fe0ac
zepumph added a commit that referenced this issue Nov 21, 2019
@zepumph
move array.from polyfill to sherpa, #817
b2a1312
zepumph added a commit to phetsims/tandem that referenced this issue Nov 21, 2019
@zepumph
move array.from polyfill to sherpa, phetsims/chipper#817
610d11f
zepumph added a commit to phetsims/tambo that referenced this issue Nov 21, 2019
@zepumph
move array.from polyfill to sherpa, phetsims/chipper#817
b0f9eb8
@zepumph zepumph mentioned this issue Nov 21, 2019
Closed
@zepumph
Copy link
Member Author

zepumph commented Nov 21, 2019

This was implemented above. @pixelzoom would you please review. Note that the scenery specific stuff that I originally wanted @jonathanolson to review has been moved to #819, so @pixelzoom feel free to close if there is nothing you see here.

@zepumph zepumph assigned pixelzoom and unassigned zepumph Nov 21, 2019
@pixelzoom
Copy link
Contributor

Looks great, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pixelzoom pixelzoom

Labels
priority:2-high status:blocks-publication status:ready-for-review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jonathanolson @pixelzoom @zepumph