More light bulb designs and implementations?

[pixelzoom]

Discovered while working on phetsims/scenery-phet#170. That issue has a lot of discussion about the benefits of consolidating lightbulb styles, and the desire to use common code for CCK. So I was dismayed to find that CCK not only punted on the problem, but has made the problem much worse by creating (at least) 3 new classes and 4 new PNG files related to lightbulbs:

• CustomLightBulbNode.js
• CCKCLightBulbNode.js
• LightBulbSocketNode.js
• lightbulb-middle.png
• lightbuld-middle-high.png
• lightbuld-middle-icon.png
• lightbuld-middle-real.png

CustomLightBulbNode.js is documented as "Forked from SCENERY_PHET/LightBulbNode", a nice way of saying "Copied". That's not going to fly for code review.

I can understand if this needed to be done to meet a milestone. But I don't see any TODO comments or Git issue indicating that this is a temporary situation, or that there's a plan to go back and align this with goals of phetsims/scenery-phet#170. So I'm creating this issue.

@samreid What is the plan for light bulb in CCK?

[samreid]

As mentioned in phetsims/scenery-phet#170 (comment)

I'm tracking the CCK aspect of this issue in #679 and will wait for this issue to be planned as a quarterly goal before going further. I confirmed this issue is listed in the spreadsheet. Self-unassigning.

[samreid]

Labeling for the AC milestone for the purposes of discussion today.

[samreid]

Question for design meeting: Is it OK to leave the light bulbs as they are until we complete the quarterly goal of organizing the common code light bulbs in #679 ?

[arouinfar]

If there is a quarterly goal related to phetsims/scenery-phet#170, we should have a meeting between designers/relevant developers to inventory the current implementations and discuss the learning goals/design needs for these variations. I personally don't think we should delay CCK: AC for a common code issue that has been sitting around for 6 years. If the scenery issue is indeed blocking, we need to devote the resources to unblock it and move CCK: AC along.

[samreid]

At today's design meeting, we agreed not to delay CCK for the common code light bulbs. Removing from the milestone.