Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BlocksValueControlPanel issues regarding tandem/ToggleNode/PhetioControlledVisibilityProperty #216

Closed
samreid opened this issue Jun 14, 2024 · 1 comment
Closed

BlocksValueControlPanel issues regarding tandem/ToggleNode/PhetioControlledVisibilityProperty #216

samreid opened this issue Jun 14, 2024 · 1 comment
Assignees
@samreid

Comments

@samreid
Copy link
Member

samreid commented Jun 14, 2024

@zepumph and I saw that BlocksValueControlPanel probably should be a ToggleNode. That may clean up its visibleProperty instrumentation. It needs to have a visibleProperty instrumented. Check if PhetioControlledVisibilityProperty is needed or can be adjusted like in #207
@samreid samreid self-assigned this Jun 14, 2024
samreid added a commit that referenced this issue Jun 17, 2024
@samreid
Use ToggleNode in BlocksValueControlPanel.ts, see #216
66749b8
samreid added a commit to phetsims/scenery that referenced this issue Jun 17, 2024
@samreid
Use ToggleNode in BlocksValueControlPanel.ts, see phetsims/density-bu…
d01d731 
…oyancy-common#216
@samreid
Copy link
Member Author

samreid commented Jun 17, 2024

Fixed. This allowed us to delete PhetioControlledVisibilityProperty since it was the only usage. We will review the studio tree in phetsims/buoyancy#51. Closing.

@samreid samreid closed this as completed Jun 17, 2024
@samreid samreid mentioned this issue Jun 17, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@samreid samreid

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@samreid