Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

create Dimension3 #97

Open
pixelzoom opened this issue Nov 22, 2019 · 3 comments
Open

create Dimension3 #97

pixelzoom opened this issue Nov 22, 2019 · 3 comments
Assignees
@jonathanolson
Labels
dev:enhancement status:ready-for-review

Comments

@pixelzoom
Copy link
Contributor

It would be nice to have DOT/Dimension3 for use in Natural Selection, and it does not currently exist. ESTIMATION/Dimension3 exists, but it's pretty raw. So I'm going to create DOT/Dimension3, with API similar to DOT/Dimension2.
@pixelzoom pixelzoom self-assigned this Nov 22, 2019
@pixelzoom
Copy link
Contributor Author

Decided that I don't need this after all in Natural Selection, so closing.

@pixelzoom
Copy link
Contributor Author

Reopening. I once again need Dimension3 -- see phetsims/faradays-electromagnetic-lab#156.

I also see that @jbphet created a sim-specific version, estimation.Dimension3.

@pixelzoom pixelzoom reopened this Apr 21, 2024
pixelzoom added a commit that referenced this issue Apr 21, 2024
@pixelzoom
create Dimension3, #97
e7ca34a
pixelzoom added a commit to phetsims/faradays-electromagnetic-lab that referenced this issue Apr 21, 2024
@pixelzoom
use Dimension3 in FEL, phetsims/dot#97, #156
8e5c5fa
pixelzoom added a commit to phetsims/estimation that referenced this issue Apr 21, 2024
@pixelzoom
use Dimension3 in estimation, phetsims/dot#97
d8b5101
@pixelzoom
Copy link
Contributor Author

@jonathanolson please review Dimension3. I copied Dimension2 and modified it. I deleted swapped because it didn't make sense. And note that Dimension3 is being used in FEL and Estimation.

@pixelzoom pixelzoom assigned jonathanolson and unassigned pixelzoom Apr 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jonathanolson jonathanolson

Labels
dev:enhancement status:ready-for-review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jonathanolson @pixelzoom