Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Descriptions for Chemistry and Zoomed-in Chemistry Book buttons are inconsistent #320

Closed
Nancy-Salpepi opened this issue Jan 6, 2023 · 2 comments

Comments

@Nancy-Salpepi
Copy link

Nancy-Salpepi commented Jan 6, 2023

Test device
iPad 9th generation

Operating System
iOS 16.1.1

Browser
safari

Problem description
For phetsims/qa#868, with mobile VO, the description of how to grab the chemistry book is heard twice while the description of how to grab the zoomed-in chemistry book is never heard.

More specifically:

  1. When the chemistry book has focus I hear, "Chemistry Book button. Double tap and hold to grab chemistry book. Lift finger to release."
  2. If I swipe again, the black focus box on the Chemistry book disappears and I hear "Double tap and hold to grab chemistry book. Lift finger to release. "
  3. Swiping again, the focus is now on the Zoomed-in Book and I hear, "Chemistry Book button."
  4. Swiping again takes me to the control area

Something similar happens with VoiceOver on the mac.

Visuals

description.doubled.or.missing.mov
Troubleshooting information: !!!!! DO NOT EDIT !!!!! Name: ‪Friction‬ URL: https://phet-dev.colorado.edu/html/friction/1.6.0-dev.28/phet/friction_all_phet.html Version: 1.6.0-dev.28 2022-12-20 18:30:08 UTC Features missing: applicationcache, applicationcache, touch Flags: pixelRatioScaling User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_7) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/108.0.0.0 Safari/537.36 Language: en-US Window: 1475x780 Pixel Ratio: 1.7999999523162842/1 WebGL: WebGL 1.0 (OpenGL ES 2.0 Chromium) GLSL: WebGL GLSL ES 1.0 (OpenGL ES GLSL ES 1.0 Chromium) Vendor: WebKit (WebKit WebGL) Vertex: attribs: 16 varying: 31 uniform: 1024 Texture: size: 16384 imageUnits: 16 (vertex: 16, combined: 32) Max viewport: 16384x16384 OES_texture_float: true Dependencies JSON: {}
@Nancy-Salpepi
Copy link
Author

I also see this on master after the fix in #317

@zepumph
Copy link
Member

zepumph commented Jan 6, 2023

I don't think this is a problem. It is a common design to have the "help text" that applies to two items in between them. In this case, it is actually part of the first interaction description, which is why you hear that and don't hear it in the zoomed in book focus text. That said, I'm going to close this because the behavior in NVDA is that you don't hear that help text automatically at all on focus, but can get to it with arrow keys as you cycle through HTML elements in the page. This behavior is what is expected by the design generally, so I would say that the extra description in one spot is just an added bonus. And not something to try to make consistent for all readers/devices.

@emily-phet @terracoda please reopen if you would like to discuss this further.

@zepumph zepumph closed this as completed Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants