Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PhET-iO instrumentation #77

Closed
pixelzoom opened this issue May 16, 2019 · 3 comments
Closed

PhET-iO instrumentation #77

pixelzoom opened this issue May 16, 2019 · 3 comments
Assignees

Comments

@pixelzoom
Copy link
Contributor

pixelzoom commented May 16, 2019

I have attempted to consider PhET-iO while architecting & implementing this sim. But with the exception of top-level model and view classes, the 1.0 release of this simulation will not be instrumented for PhET-iO.

This issue is where I'll capture miscellaneous notes that will be useful for future instrumentation. It might be useful to have the design team review these notes before publishing 1.0.

@pixelzoom
Copy link
Contributor Author

pixelzoom commented Jun 11, 2019

I experimented with using ObservableArray to store Particles, more details in In #116. The thought was that this would be a quick way to save/restore state of the particle system, get access to particles, etc. The performance was significantly compromised, so beware about going down that path when this sim is instrumented.

@pixelzoom
Copy link
Contributor Author

Since the 1.0 branch was created, there have been extensive PhET0-iO changes that were not patched into the 1.0 branch. When it's time to do a brand=phet-io release, plan on doing it in a new branch, with master shas, and a complete QA process.

pixelzoom added a commit that referenced this issue Mar 19, 2024
pixelzoom added a commit that referenced this issue Mar 19, 2024
@pixelzoom pixelzoom changed the title PhET-iO instrumentation notes PhET-iO instrumentation Mar 19, 2024
@pixelzoom pixelzoom self-assigned this Apr 3, 2024
pixelzoom added a commit that referenced this issue Apr 30, 2024
pixelzoom added a commit to phetsims/scenery-phet that referenced this issue Apr 30, 2024
pixelzoom added a commit that referenced this issue Apr 30, 2024
pixelzoom added a commit that referenced this issue Apr 30, 2024
pixelzoom added a commit that referenced this issue May 1, 2024
pixelzoom added a commit that referenced this issue May 1, 2024
pixelzoom added a commit that referenced this issue May 8, 2024
pixelzoom added a commit that referenced this issue May 8, 2024
pixelzoom added a commit that referenced this issue May 9, 2024
This reverts commit 1601098.
pixelzoom added a commit that referenced this issue May 9, 2024
pixelzoom added a commit that referenced this issue May 9, 2024
pixelzoom added a commit that referenced this issue May 9, 2024
pixelzoom added a commit that referenced this issue May 9, 2024
pixelzoom added a commit that referenced this issue May 9, 2024
pixelzoom added a commit that referenced this issue May 9, 2024
pixelzoom added a commit that referenced this issue May 13, 2024
pixelzoom added a commit that referenced this issue May 13, 2024
pixelzoom added a commit that referenced this issue May 13, 2024
pixelzoom added a commit that referenced this issue May 13, 2024
@pixelzoom
Copy link
Contributor Author

PhET-iO instrumentation is complete. Any additional work will be new features or change requests, to be tracked in other GitHub issues. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant