Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sim title should be scaled to fit on home screen #129

Closed
pixelzoom opened this issue Jun 5, 2014 · 4 comments
Closed

sim title should be scaled to fit on home screen #129

pixelzoom opened this issue Jun 5, 2014 · 4 comments

Comments

@pixelzoom
Copy link
Contributor

Example, running with '?dev' to show screen bounds:

screenshot_273

@samreid
Copy link
Member

samreid commented Jun 11, 2014

I've assigned this to myself, not sure when I will get to it. If someone else want to fix it before I get there, be my guest!

@pixelzoom
Copy link
Contributor Author

BCE is now in the functional-review stage and this is not fixed yet. High priority or this will become a blocking issue.

pixelzoom added a commit that referenced this issue Jun 17, 2014
@pixelzoom
Copy link
Contributor Author

I fixed this so that the title is at most 90% of the screen width. Here's the relevant line of code in joist.HomeScreen:

title.scale( Math.min( 1, 0.9 * this.layoutBounds.width / title.width ) );

Here's the Balancing Chemical Equations home screen (?dev):

screenshot_304

Since this was relatively trivial, I'm going to close it without asking for review. If someone wants to review it (or change it), go for it.

@samreid
Copy link
Member

samreid commented Jun 17, 2014

Change set and screenshot look good to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants