Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

paper.js dependency results in increased size for all sims. #101

Open
pixelzoom opened this issue Jul 13, 2023 · 1 comment
Open

paper.js dependency results in increased size for all sims. #101

pixelzoom opened this issue Jul 13, 2023 · 1 comment
Assignees

Comments

@pixelzoom
Copy link
Contributor

pixelzoom commented Jul 13, 2023

@jonathanolson added paper.js as a dependency for all sims for "Handling quadratic/cubic intersection with bezier clipping". There was no associated GitHub issue, but for example see phetsims/graphing-quadratics@d6b9aa9.

This increased the size of all sims. For graphing-quadratics, it's ~10% increase, see below.

Is this expected and acceptable? It seems like a steep price to pay for this one feature.

Before paper.js:

-rw-r--r-- 1 cmalley staff 22782949 Jul 12 11:20 graphing-quadratics_all_phet_debug.html
-rw-r--r-- 1 cmalley staff 2073566 Jul 12 11:20 graphing-quadratics_en_phet.html

After paper.js

-rw-r--r-- 1 cmalley staff 23185232 Jul 12 12:58 graphing-quadratics_all_phet_debug.html
-rw-r--r-- 1 cmalley staff 2286405 Jul 12 12:58 graphing-quadratics_en_phet.html

@jonathanolson
Copy link
Contributor

It should be possible to port that section of the code (or reimplement from the papers/literature), I'll look into that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants