-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Instrument inputEnabledProperty #101
Comments
phetsims/scenery#1116 is complete and out for review. You can add the following option to instrument
This can be done in your sim for common code components also, but any changes needed inside common code will be done in phetsims/scenery#1158. |
Here's a description of the sim-specific The diatomic molecule has only one DragListener (for rotating), so requires only one element:
The triatomic molecule has a DragListener for each atom and bond, and they can be individually controlled via these elements:
The triatomic molecule also has this element at the top-level. Setting it to
@arouinfar @kathy-phet please review in master. Anything else for sim-specific Next we should discuss what needs to be completed for common-code |
3/18/21 design meeting: @arouinfar @kathy-phet @pixelzoom Need to turn off hint arrows for triatomic atoms that are inputEnabledProperty false. |
Done in the above commit. This was a little tricky because the visiblity of ech hint arrow involves 3 things: inputEnabledProperty for the molecule, inputEnabledProperty for the atom, and whether the user has changed the molecule. @arouinfar ready for review. |
@pixelzoom looks good on the Three Atoms screen, but I think we'll want to do the same for the Two Atoms screen and have |
Looks good in master @pixelzoom. |
Related to #85, and after phetsims/scenery#1116 has been completed...
Instrument
inputEnabledProperty
for the following Nodes:DiatomicMoleculeNode
TriatomicMoleculeNode
atomANode
atomBNode
atomCNode
bondABNode
bondBCNode
Discuss the plan for common-code UI components used by this sim:
The text was updated successfully, but these errors were encountered: