-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
credits #2
Comments
Is this new? I am used to seeing original developers and designers listed in those respective categories, not put in the team. Looking at the recently published PhET sim ports, Gas Props follows this convention, but Blackbody, EFAC, Fractions Intro, Build a Fraction, do not. Curve Fitting similarly doesn't follow this convention. @ariel-phet can you clarify. |
I don't know what other developers have been doing. But if I reuse or port parts of the Java sim, then I definitely list the original Java developer as "developer" because their code is part of the HTML5 implementation. That was certainly the case in Gas Properties, specifically for collision detection. That is not likely to be the case for Natural Selection. And I'll be happy to revisit when HTML5 implementation is done. |
@amanda-phet the Java version of Gas Properties does not explicitly credit anyone as the lead designer, which is why I'm the only lead listed in the HTLM5 credits. Generally speaking, I'm always co-listed with the Java lead in HTML5 credits. @pixelzoom sounds like you intended to credit Ron LeMaster as a developer in Gas Props, but he is in the Team section of the credits. |
Hmm... I guess I did strictly follow the "move Java credits to team" policy. I don't think Ron cares, I'll buy him a beer ;) If someone wants to specify a different policy, please do and I'll follow it. And if the checklist is being followed, there are multiple opportunities to adjust the credits before a sim is published. That's why this issue exists. |
@pixelzoom @amanda-phet @arouinfar my understanding went something like this... For ports, we list the original lead designer in the Lead Design, but generally if there have been significant changes, we put the HTML5 lead first. (So for instance, current Vector Addition lists Mike Dubson first in lead design, but probably Amy should be listed first there) For software development, if the code is basically the same as the Legacy code, it seems correct to include the original software developer, but certainly recently, most of the code has basically been written from scratch. I think this is mostly developer discretion. In team, we just list people alphabetically. I cannot say I have personally been too worried as long as people are listed (but that is because I personally don't care about credits too much). But the above is my understanding of our decisions. |
Thanks @ariel-phet. @amanda-phet @arouinfar let me know if you want to make changes to the "Lead Design" credit in Natural Selection and Vector Addition respectively. (EDIT: No changes required to Vector Addition credits, see phetsims/vector-addition#98 (comment).) I'll decide on the "Software Development" credit when we see whether any of the Java implementation gets incorporated into the HTML5 version (so far not). |
I've added @phet-steele to the credits, for his role in testing the prototype release. |
@KatieWoe I've added Logan Bray to the QA credits, for his role in 1.2 RC testing. (Unfortunately he will not appear in the 1.2 credits, but it's not a public release, it's just a link that's going to a client for temporary use.). Anyone else that I should add? |
I think Liam should be added as well. |
I've added Liam. |
Looks like I forgot to close this after publishing 1.2. Closing. |
Update credits in natural-selection-main.js.
The text was updated successfully, but these errors were encountered: