Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Translator punctuation errors #226

Closed
Tracked by #932
Nancy-Salpepi opened this issue Apr 10, 2023 · 6 comments
Closed
Tracked by #932

Translator punctuation errors #226

Nancy-Salpepi opened this issue Apr 10, 2023 · 6 comments

Comments

@Nancy-Salpepi
Copy link

Test device
MacBook Air M1 chip

Operating System
13.2.1

Browser
Safari and Chrome

Problem description
For phetsims/qa#929, the "Word" box on the Ten and Twenty screens has punctuation issues with some translations.

  • French: missing closing parenthesis

Screenshot 2023-04-03 at 9 10 39 PM

  • Hausa: missing parenthesis

Screenshot 2023-04-08 at 3 24 39 PM

  • Dansk: closing parenthesis replaced with curly bracket

Screenshot 2023-04-08 at 3 25 44 PM

@chrisklus
Copy link
Contributor

From 4/11 standup with @zepumph and @Nancy-Salpepi:

We are at least curious to check in with @jbphet to see if we can make some edits in babel to make these a bit better. We will spend 10 minutes on a patch.

@zepumph
Copy link
Member

zepumph commented Apr 12, 2023

Just a note here that we want to make sure to change the number-play strings, and not the number-suite-common strings, because we will blow away those strings over in phetsims/number-suite-common#27.

@chrisklus
Copy link
Contributor

@jbphet gave the all good here and pointed me to https://github.com/phetsims/rosetta/blob/master/doc/admin-guide.md#triggering-a-rebuild-without-being-credited in case we ever need to do something like this after publication.

In the above commits I fixed French and Dansk because they were pretty clearly typos and were intending to use parenthesis.

I didn't feel confident enough to change Hausa because they didn't include any parenthesis (or a space). I did some googling and also asked ChatGPT about the use of parenthesis in the language. The best I could find what that they aren't very common and the examples that I saw used them in the way English uses them when someone is saying "in other words", like repeating the same thing that was just said for clarification or translation. So if that is true, I could understand how using parenthesis would be wrong here. Maybe smashing the two words together is the closest thing to saying "Word, but in Italian". This is all speculation, but I'm just trying to say that I don't feel knowledgeable enough to change the translation. Id anyone disagrees, please comment! We can add another patch in the next RC.

I tested Dansk and French on phettest and they are looking great, marking ready to cherry-pick

@chrisklus
Copy link
Contributor

chrisklus commented Apr 13, 2023

Or wait, babel isn't a dependency lol. I'll leave open for a bit if anyone else wants to comment and for RC spot check.

@zepumph
Copy link
Member

zepumph commented Apr 13, 2023

For QA: From the first comment: the first and last screenshots should not be fixed, but we decided against adding parens to a language for the second screenshot (hausa).

UPDATE: please note that this issue for number-play will also be handled more generally in phetsims/babel#22.

@Nancy-Salpepi
Copy link
Author

Looks good in rc.2. Closing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants