Instrument for PhET-iO

[zepumph]

@emily-phet and I discussed and we think that this would be a good step to take to advance the sonification side of accessibility on this sim.

https://github.com/phetsims/phet-io/blob/ee0a5b85ea06039c2871a8d3d95207c1dfc73e33/doc/how-to-instrument-a-phet-simulation-for-phet-io.md

Overview of instrumentation steps:

• Copy this checklist to the issue description (top issue comment) for tracking. Make sure to use a permanent link like /blob/<SHA>/ so that the specific guide you used is preserved.
• Understand the goal
• Code review
• Use Property instead of PropertySet
• Import Tandem to main.js
• Create root tandem
• Pass tandems to sim screens
• Pass tandems to model and view
• Pass tandems to all constructors defined by the simulation
  • See also Testing while adding Tandem instances. Test with ?phetioValidateTandems=false since some common code-components don't yet have tandems.
• Pass tandem instances to common code components
  • See also Testing while adding Tandem instances.
• Create static tandems where appropriate.
• Replace types with tandemized equivalents
• Instrument any uninstrumented common-code components used by the sim
• Instrument new component types defined by the sim
• Add simulation specific support
• Support dynamic state
• Make sure Joist dt values are used instead of Date.now() or other Date functions. This is necessary for reproducible playback via input events.
• Are random numbers using phet.joist.random, and all doing so after modules are declared (non-statically)? For instance, the following methods (and perhaps others) should not be used: Math.random, _.shuffle, _.sample, _.random
• undefined values cannot be saved by phet-io, sims should be written to use null instead
• Verify that the simulation works in all of the phet-io wrappers
• Add this sim to the list of phet-io sims in chipper/data/test-phetio
• Build with grunt --brand=phet-io and test the built version by launching build/wrappers/index and testing all the links
• Set up a task to have the newly instrumented sim tested by the QA team
• Update these instructions if you find them to be incomplete, inconsistent or incorrect
• After publishing, add your instrumented simulation to the spreadsheet here: https://docs.google.com/spreadsheets/d/1pU9izdNQkd9vr8TvLAfXe_v68yh-7potH-y712FBPr8/edit#gid=0

[zepumph]

We just want to release this for sonification work, not necessarily testing it completely and fully. On hold until we figure out https://github.com/phetsims/phet-io/issues/1170

[zepumph]

We decided to go ahead and ready a phet-io dev version that can be used with the sonification process. I will talk with @phet-steele about what a phet-io dev test would look like. In the mean time I'll make a dev test.

[zepumph]

http://www.colorado.edu/physics/phet/dev/html/ohms-law/1.4.0-phetiodev.1/wrappers/index/

tested in phetsims/qa#18

on hold until that gets sorted out

[zepumph]

http://www.colorado.edu/physics/phet/dev/html/ohms-law/1.4.0-phetiodev.3/wrappers/index/

has been released. This is not a published version, but a dev version. I will mark it in the spreadsheet as fully instrumented, even though there is not yet a deliverable link on the phet-io website. Closing.