Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use scale instead of overwriting the matrix each time the current changes #57

Closed
zepumph opened this issue Jun 25, 2017 · 1 comment
Closed
Assignees

Comments

@zepumph
Copy link
Member

zepumph commented Jun 25, 2017

It seems wrong to do have this line in a link function in RightAngleArrow.js:

`  self.matrix = Matrix3.scale( scale );`

When I converted RightAngleArrow.js to inherit from Path, this line ruined the transform unless I added a mutate call under it:

      self.matrix = Matrix3.scale( scale );
      self.mutate( options );

I don't yet know how I should fix it.

@zepumph
Copy link
Member Author

zepumph commented Jun 26, 2017

this issue is from code review: #51

@jessegreenberg and I were able to simplify this operation nicely, closing

@zepumph zepumph closed this as completed Jun 26, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant