-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Screenshot? #59
Comments
from code review: #51 |
@zepumph screenshots need to be taken on a retina iPad (I do this on one we have in the office). From there, they are resized to be exactly 1248x1344. Then, they are checked in to master and any relevant production branch. The easiest way to update the screenshot on the website is to do a maintenance (or brand new) release after it has been checked in. So, I'd be willing to take a screenshot for this sim. What branches would need it? 1.3 and master? Are we doing a maintenance release soon from 1.3? |
Just master is good, after thinking a bit more. This would probably be good to do after RC testing, just in case things change a bit. I would hate for you to have to do it twice. |
They are usually done right before release anyway so I can wait! |
On hold until we are going to publish new versions |
This is now in RC (phetsims/qa#313), so I think it is a good idea to take off hold and do now. @zepumph do you agree? |
Yes sounds good. |
@arouinfar I matched the numerical values of the screenshots, but the sizes of the equation are different. Are these the screenshots you want? |
Those look good to me @KatieWoe, thanks! |
That should do it @arouinfar and @zepumph |
Thanks @KatieWoe, looks good! |
It seems like we need a new screenshot here. I updated the slider thumbs, and the right angle arrows match the 'I' in the formula instead of the resistor now. Here is what master looks like. @phet-steele how should I go about getting this updated?
The text was updated successfully, but these errors were encountered: