Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Screenshot? #59

Closed
zepumph opened this issue Jun 25, 2017 · 11 comments
Closed

Update Screenshot? #59

zepumph opened this issue Jun 25, 2017 · 11 comments
Assignees

Comments

@zepumph
Copy link
Member

zepumph commented Jun 25, 2017

It seems like we need a new screenshot here. I updated the slider thumbs, and the right angle arrows match the 'I' in the formula instead of the resistor now. Here is what master looks like. @phet-steele how should I go about getting this updated?

image

@zepumph
Copy link
Member Author

zepumph commented Jun 26, 2017

from code review: #51

@phet-steele
Copy link

phet-steele commented Jun 26, 2017

@zepumph screenshots need to be taken on a retina iPad (I do this on one we have in the office). From there, they are resized to be exactly 1248x1344. Then, they are checked in to master and any relevant production branch. The easiest way to update the screenshot on the website is to do a maintenance (or brand new) release after it has been checked in.

So, I'd be willing to take a screenshot for this sim. What branches would need it? 1.3 and master? Are we doing a maintenance release soon from 1.3?

@zepumph
Copy link
Member Author

zepumph commented Jun 26, 2017

Just master is good, after thinking a bit more. This would probably be good to do after RC testing, just in case things change a bit. I would hate for you to have to do it twice.

@phet-steele
Copy link

This would probably be good to do after RC testing, just in case things change a bit.

They are usually done right before release anyway so I can wait!

@zepumph
Copy link
Member Author

zepumph commented Jun 26, 2017

On hold until we are going to publish new versions

@zepumph zepumph removed their assignment Mar 15, 2018
@phet-steele phet-steele assigned ghost and unassigned phet-steele May 10, 2018
@ghost ghost assigned KatieWoe Jul 20, 2018
@KatieWoe
Copy link
Contributor

KatieWoe commented May 2, 2019

This is now in RC (phetsims/qa#313), so I think it is a good idea to take off hold and do now. @zepumph do you agree?

@KatieWoe KatieWoe assigned zepumph and unassigned ghost May 2, 2019
@zepumph
Copy link
Member Author

zepumph commented May 2, 2019

Yes sounds good.

@KatieWoe
Copy link
Contributor

KatieWoe commented May 2, 2019

@arouinfar I matched the numerical values of the screenshots, but the sizes of the equation are different. Are these the screenshots you want?
ohms-law-screenshot
ohms-law-screenshot-alt1

@arouinfar
Copy link

Those look good to me @KatieWoe, thanks!

KatieWoe added a commit that referenced this issue May 3, 2019
KatieWoe added a commit that referenced this issue May 3, 2019
@KatieWoe
Copy link
Contributor

KatieWoe commented May 3, 2019

That should do it @arouinfar and @zepumph

@KatieWoe KatieWoe assigned arouinfar and unassigned KatieWoe May 3, 2019
@arouinfar
Copy link

Thanks @KatieWoe, looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants