Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace Camera with Scenery Display to support Virtual programs #221

Open
brettfiedler opened this issue Feb 6, 2024 · 1 comment
Open

Comments

@brettfiedler
Copy link
Contributor

We will be prioritizing enhancing the virtual experience. One solution we discussed in design meeting was to revamp the Camera screen itself to allow users to swap between the physical+virtual+camera or the virtual-only experience.

Ideas and mockups to go into this issue.

@brettfiedler to detail out needs for two-state screen and provide mockups

@brettfiedler
Copy link
Contributor Author

brettfiedler commented Feb 13, 2024

If we're replacing the current camera interface with a scenery display, we need to consider how we switch between the camera and virtual display, and how we ensure current features related to the preview programs and to camera calibration are retained/integrated. The biggest question I have is: Which features are best to integrate into a scenery display for reduced complexity and maintenance? Which are best left in the React framework?

Preview Program Features in Sidebar

  • Add Virtual Papers
  • Add Virtual Markers
  • Hide/Display virtual paper Whiskers (in Detection > Overlays currently)

Camera Detection Features in Sidebar

  • Calibration Circles
  • Detection Parameters
  • Display/Hide Keypoint Circles, Detected Corner Numbers, & other Overlays
  • Flip X/Y
  • Camera Selection

Space Management Features

  • Space selection dropdown
  • Create new space
  • Open JS editor page
  • ((create new JS))
  • ((preview editor))
  • ((delete program))
  • ((save to DB))

Misc Features

  • Print paper
  • Printing size

Simplest Change to Camera

The simplest change would involve leaving as much of the React interface intact and replacing only the camera feed/area around the camera feed with a scenery display. Adding/removing Programs, markers, etc would exist as they are in the sidebar. I'm not sure how much complexity this adds in connecting the react components to the scenery display.

  • Button or tabs to switch between Camera and Virtual play.
  • Camera is turned off when switched to Virtual for performance increase.
  • (optionally) Camera sidebar features are hidden when Virtual play is selected.

image

image

More complex and integrated display

We could also try embedding more of the sidebar into the display. There's been interest in a "drag-n-drop" interface for papers, so this could be placed in the display itself. Then Preview Markers and whisker enabling could also appear there.

image

image

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant