non-standard energy colors

[pixelzoom]

Noted while investigating phetsims/scenery-phet#455.

PhetColorScheme:

var RED_COLORBLIND = new Color( 255, 85, 0 );
var TAN_ORANGE = new Color( 236, 153, 55 );

HEAT_THERMAL_ENERGY: RED_COLORBLIND,
...
KINETIC_ENERGY: Color.GREEN,  // 0,255,0
...
POTENTIAL_ENERGY: Color.BLUE, // 0,0,255
...
TOTAL_ENERGY: TAN_ORANGE,

PendulumLabColors:

    // Energy colors
    KINETIC_ENERGY_COLOR: 'rgb( 31, 202, 46 )',
    POTENTIAL_ENERGY_COLOR: 'rgb( 55, 132, 213 )',
    THERMAL_ENERGY_COLOR: 'rgb( 253, 87, 31 )',
    TOTAL_ENERGY_COLOR: 'rgb( 0, 0, 0 )',

This sim is using totally different colors for energy. @arouinfar is there any reason why this sim should not be using PhetColorScheme?

[arouinfar]

Thanks @pixelzoom. All PhET sims should use the same colors for the various energies, but PhetColorScheme is a bit antiquated. Changes to PhetColorScheme will be discussed in phetsims/scenery-phet#456, so marking this as status:on-hold until that issue is resolved.

[arouinfar]

@jonathanolson, in phetsims/scenery-phet#456 the colors used for energy were updated in PhetColorScheme.js. Pendulum Lab should be using PhetColorScheme for KINETIC_ENERGY_COLOR, POTENTIAL_ENERGY_COLOR, and THERMAL_ENERGY_COLOR.

Since the total energy is represented by a stacked bar, rather than a solid one, I do not believe TOTAL_ENERGY_COLOR needs to be changed at this time. The color specified in PendulumLabColors corresponds to the text label below the bar, and black is an appropriate choice here.