Support lint in all release branches #347
Assignees
Comments
|
On hold until phetsims/phetcommon#63 is MR'd. |
|
I found one to work on: This is because all/tsconfig doesn't include |
|
The above problem was the only other one discovered: |
|
Ok, the number-line-integers lint fix was pushed and deployed over in phetsims/number-line-integers#132.
I'm tempted to use ReleaseBranch which is already doing something quite similar to this, but outfitting it for |
Subject: [PATCH] add author annotations (lint fix), https://github.com/phetsims/chipper/issues/1414
---
Index: js/common/ReleaseBranch.js
IDEA additional info:
Subsystem: com.intellij.openapi.diff.impl.patch.CharsetEP
<+>UTF-8
===================================================================
diff --git a/js/common/ReleaseBranch.js b/js/common/ReleaseBranch.js
--- a/js/common/ReleaseBranch.js (revision 78025b7ae6064e9ab5260cea5e532f3bf24c3ec8)
+++ b/js/common/ReleaseBranch.js (date 1704483548021)
@@ -46,6 +46,7 @@
module.exports = ( function() {
const MAINTENANCE_DIRECTORY = '../release-branches';
+ const MAIN_RELEASE_BRANCHES_DIRECTORY = '../release-branches-main';
class ReleaseBranch {
/**
@@ -192,16 +193,34 @@
);
}
+ /**
+ * @public
+ */
+ static async updateCheckoutFromMain( repo ) {
+ // get phetlibs
+ // implementation( dependencies);
+ await ReleaseBranch.ensureDirectory( MAIN_RELEASE_BRANCHES_DIRECTORY );
+
+ }
+
+ /**
+ * @private
+ */
+ static async ensureDirectory( directory = MAINTENANCE_DIRECTORY ) {
+ if ( !fs.existsSync( directory ) ) {
+ winston.info( `creating directory ${directory}` );
+ await createDirectory( directory );
+ }
+ }
+
/**
* @public
*/
async updateCheckout( overrideDependencies = {} ) {
winston.info( `updating checkout for ${this.toString()}` );
- if ( !fs.existsSync( MAINTENANCE_DIRECTORY ) ) {
- winston.info( `creating directory ${MAINTENANCE_DIRECTORY}` );
- await createDirectory( MAINTENANCE_DIRECTORY );
- }
+ await ReleaseBranch.ensureDirectory();
+
const checkoutDirectory = ReleaseBranch.getCheckoutDirectory( this.repo, this.branch );
if ( !fs.existsSync( checkoutDirectory ) ) {
winston.info( `creating directory ${checkoutDirectory}` ); |
To be done in phetsims/aqua#202. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
From conversation with @jonathanolson in phetsims/phetcommon#63. We know that lint is working on all release branches as of 2 months ago because of an MR on all sims. The Maintenance tooling runs perennial's
grunt rctask, which lints. But what we don't know if we support is linting with only dependencies checked out. We found one error in my PhET-iO Hydrogen MR in phetsims/phetcommon#63. There may be more, the path to test is is:That will hit everything, check it out, built it, and lint it.
Good luck us!
The text was updated successfully, but these errors were encountered: