Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review inputEnabledProperty #214

Closed
pixelzoom opened this issue Mar 18, 2021 · 3 comments
Closed

Review inputEnabledProperty #214

pixelzoom opened this issue Mar 18, 2021 · 3 comments

Comments

@pixelzoom
Copy link
Contributor

phetsims/scenery#1158 changed pickableProperty to inputEnabledProperty. Review this sim's use of inputEnbledProperty.

@pixelzoom
Copy link
Contributor Author

Review is done, and there were significant changes required. Here's a summary of where things are at.

There are 3 inputEnabledProperty elements in this sim.

In the Macro screen, input for the pH probe can be disabled using:

phScale.macroScreen.view.pHMeterNode.probeNode.inputEnabledProperty

In the My Solution screen, the H2O+ and OH- graph indicators are interactive. When input is disabled, their arrows are hidden. Input can be disabled using:

phScale.mySolutionScreen.view.graphNode.logarithmicGraphNode.indicatorH3ONode.inputEnabledProperty
phScale.mySolutionScreen.view.graphNode.logarithmicGraphNode.indicatorOHNode.inputEnabledProperty

Over to @arouinfar for review.

@pixelzoom
Copy link
Contributor Author

I see that inputEnabledProperty was not added to the dropper, and @kathy-phet had mentioned that as a specific use case. Let's discuss that in #215.

@pixelzoom
Copy link
Contributor Author

Reviewed changes with @arouinfar, and client guides look OK. Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants