-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uninstrument Text and RichText #287
Comments
At the same time ashttps://github.com/phetsims/beers-law-lab/issues/332, I'm going to do this eagerly, to see how adding migration rules goes. @samreid @zepumph FYI. |
In general, if a Text/RichText has any featured child elements, consult with @arouinfar before uninstrumenting. I also discussed associated derived string Properties with @arouinfar. If they are used to labels a control, keep them instrumented. If they are are readouts of values that available elsewhere, remove instrumentation. |
Done in the above commits. Also note that ABSwitch element ( These changes should be reviewed by the PhET-iO designer before republishing. |
... the next time this sim is published. This will be an API change, and will require migration rules.
The text was updated successfully, but these errors were encountered: