Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uninstrument Text and RichText #287

Open
pixelzoom opened this issue Jul 26, 2023 · 4 comments
Open

Uninstrument Text and RichText #287

pixelzoom opened this issue Jul 26, 2023 · 4 comments

Comments

@pixelzoom
Copy link
Contributor

... the next time this sim is published. This will be an API change, and will require migration rules.

@zepumph
Copy link
Member

zepumph commented Sep 7, 2023

phetsims/joist#934

@pixelzoom
Copy link
Contributor Author

At the same time ashttps://github.com/phetsims/beers-law-lab/issues/332, I'm going to do this eagerly, to see how adding migration rules goes. @samreid @zepumph FYI.

@pixelzoom pixelzoom self-assigned this Sep 11, 2023
@pixelzoom
Copy link
Contributor Author

pixelzoom commented Sep 11, 2023

waterFaucetNode.waterText should remaining instrumented, because waterFaucetNode.waterText.visibleProperty is featured.

In general, if a Text/RichText has any featured child elements, consult with @arouinfar before uninstrumenting.

I also discussed associated derived string Properties with @arouinfar. If they are used to labels a control, keep them instrumented. If they are are readouts of values that available elsewhere, remove instrumentation.

pixelzoom added a commit that referenced this issue Sep 11, 2023
@pixelzoom
Copy link
Contributor Author

pixelzoom commented Sep 11, 2023

Done in the above commits.

Also note that ABSwitch element (graphScaleSwitch and graphUnitsSwitch) are now more sparsely instrumented, to conform to the decisions made in phetsims/sun#853 and phetsims/acid-base-solutions#190.

These changes should be reviewed by the PhET-iO designer before republishing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants