Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should eraser clear the timer? #297

Closed
Tracked by #1079
KatieWoe opened this issue Apr 17, 2024 · 6 comments
Closed
Tracked by #1079

Should eraser clear the timer? #297

KatieWoe opened this issue Apr 17, 2024 · 6 comments

Comments

@KatieWoe
Copy link

Test device
ChromeBook
Operating System
ChromeOS
Browser
Chrome
Problem description
For phetsims/qa#1068
When you press the eraser button the timer does not reset, even though the projectile it measured is gone. This may need a second look.

@matthew-blackman
Copy link
Contributor

Reviewed this with @samreid and all looks good. Labeling ready to cherry-pick.

@matthew-blackman
Copy link
Contributor

Please close after verifying.

@KatieWoe
Copy link
Author

Seems fixed. I did notice that this may be complicated by switching fields. As it is, the timer is not affected by switching fields, so if you start it and switch fields, it is still active, and if you erase the new field the time is reset, even thought the ball it was originally measuring still exists in the first field. At this point this is so minor and I'm not sure another behavior would actually be preferable. But I wanted to check before closing.

@samreid samreid removed their assignment Apr 29, 2024
@Nancy-Salpepi
Copy link

I noticed the same behavior @KatieWoe reported in #297 (comment) while I was testing over the weekend.

@matthew-blackman
Copy link
Contributor

Great find @KatieWoe and @Nancy-Salpepi! Continuing over in #320. Can this issue be closed?

@KatieWoe
Copy link
Author

Sure!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants