-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Should eraser clear the timer? #297
Comments
Reviewed this with @samreid and all looks good. Labeling ready to cherry-pick. |
(cherry picked from commit 4365b4d)
Please close after verifying. |
Seems fixed. I did notice that this may be complicated by switching fields. As it is, the timer is not affected by switching fields, so if you start it and switch fields, it is still active, and if you erase the new field the time is reset, even thought the ball it was originally measuring still exists in the first field. At this point this is so minor and I'm not sure another behavior would actually be preferable. But I wanted to check before closing. |
I noticed the same behavior @KatieWoe reported in #297 (comment) while I was testing over the weekend. |
Great find @KatieWoe and @Nancy-Salpepi! Continuing over in #320. Can this issue be closed? |
Sure! |
Test device
ChromeBook
Operating System
ChromeOS
Browser
Chrome
Problem description
For phetsims/qa#1068
When you press the eraser button the timer does not reset, even though the projectile it measured is gone. This may need a second look.
The text was updated successfully, but these errors were encountered: