Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RC Test Ohms Law 1.4.0-rc.3 #327

Closed
3 tasks done
jessegreenberg opened this issue May 24, 2019 · 8 comments
Closed
3 tasks done

RC Test Ohms Law 1.4.0-rc.3 #327

jessegreenberg opened this issue May 24, 2019 · 8 comments

Comments

@jessegreenberg
Copy link
Contributor

jessegreenberg commented May 24, 2019

@emily-phet @terracoda @jbphet @KatieWoe Ohms Law 1.4.0-rc.3 is ready for an RC spot check. This comes after #313. rc.2 was skipped only because I encountered an error during the build process while trying to build RC 2.

Changes from the last RC are small enough that we don't need to do another full RC. Please just verify that the following issues are resolved and then a quick spot check that all seems well.

Link to RC: https://phet-dev.colorado.edu/html/ohms-law/1.4.0-rc.3/phet/ohms-law_en_phet.html

Issues to spot check:

Assigning to @ariel-phet to prioritize.

@KatieWoe
Copy link
Contributor

KatieWoe commented May 24, 2019

  • Win 10 chrome (with and without Jaws)
  • Win 10 firefox (with and without NVDA)
  • Win 10 edge

  • Mac 10.14 chrome
  • Mac 10.14 firefox
  • Mac 10.14 safari (with and without VO)

  • Win 7 IE
  • Mac 10.11 safari

  • ChromeOS
  • iOS 12 (with and without VO)

@jessegreenberg to approve test devices

@jessegreenberg
Copy link
Contributor Author

A quick check over the above list would be great @KatieWoe, thanks.

@ariel-phet ariel-phet removed their assignment May 28, 2019
@KatieWoe
Copy link
Contributor

KatieWoe commented May 28, 2019

Some odd behavior from jaws. Highlights large and seemingly unrelated area. This large highlight is also seen in Mac VO. Also phetsims/resistance-in-a-wire#177 shows up, but the actual value isn't read (if I recall correctly, it should). @jessegreenberg to determine if an issue should be made.
https://drive.google.com/file/d/116L6UpV235rqAKw6ILUWwsoO_X7LCbL4/view?usp=sharing

@KatieWoe
Copy link
Contributor

@jessegreenberg should iframe and xhtml be tested as well?

@jessegreenberg
Copy link
Contributor Author

Thanks @KatieWoe , I will take a look at the above issue. No need to test xhtml and iframes, changes were not substantial enough.

@KatieWoe
Copy link
Contributor

QA is done

@jessegreenberg
Copy link
Contributor Author

Thanks @KatieWoe, Ill make an issue for #327 (comment), then close this.

@jessegreenberg
Copy link
Contributor Author

Issues made, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants