Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RC Test: Friction 1.6.0-rc.1 #886

Closed
6 tasks done
zepumph opened this issue Jan 19, 2023 · 13 comments
Closed
6 tasks done

RC Test: Friction 1.6.0-rc.1 #886

zepumph opened this issue Jan 19, 2023 · 13 comments

Comments

@zepumph
Copy link
Member

zepumph commented Jan 19, 2023

RC Test

Mentions: @emily-phet @terracoda @BLFiedler @jessegreenberg

Simulation links

Test Matricies

Features included

  • PhET-iO
  • Alternative Input
  • UI Sound
  • Sonification
  • Description
  • Voicing

Focus and Special Instructions

  • This simulation does not include PhET-iO migration.
  • This simulation does include dynamic locale and dynamic strings features.

For QA...

General features

What to Test

  • Click every single button.
  • Test all possible forms of input.
    • Test all mouse/trackpad inputs.
    • Test all touchscreen inputs.
  • If there is sound, make sure it works.
  • Make sure you can't lose anything.
  • Play with the sim normally.
  • Try to break the sim.
  • Test all query parameters on all platforms. (See QA Book for a list of query parameters.)
  • Download HTML on Chrome and iOS.
  • Make sure the iFrame version of the simulation is working as intended on all platforms.
  • Make sure the XHTML version of the simulation is working as intended on all platforms.
  • Complete the test matrix.
  • Don't forget to make sure the sim works with Legends of Learning.
  • Test the Game Up harness on at least one platform.
  • Check this LoL
    spreadsheet and notify AR or AM if it not there.
  • If this is rc.1 please do a memory test.
  • When making an issue, check to see if it was in a previously published version.
  • Try to include version numbers for browsers.
  • If there is a console available, check for errors and include them in the Problem Description.
  • As an RC begins and ends, check the sim repo. If there is a maintenance issue, check it and notify developers if there is a problem.
  • As the RC ends, please review the QA credits in the about dialog. If the QA credits are complete and correct, please add a comment in the RC test issue indicating so. If not, please open a new issue and specify what changes should be made.

PhET-iO features

What to Test

  • Make sure that public files do not have password protection. Use a private browser for this.
  • Make sure that private files do have password protection. Use a private browser for this.
  • Make sure standalone sim is working properly.
  • Make sure the wrapper index is working properly.
  • Make sure each wrapper is working properly.
  • Launch the simulation in Studio with ?stringTest=xss and make sure the sim doesn't navigate to youtube
  • For newer PhET-iO wrapper indices, save the "basic example of a functional wrapper" as a .html file and open it. Make
    sure the simulation loads without crashing or throwing errors.
  • Load the login wrapper just to make sure it works. Do so by adding this link from the sim deployed root:
    /wrappers/login/?wrapper=record&validationRule=validateDigits&&numberOfDigits=5&promptText=ENTER_A_5_DIGIT_NUMBER
    
    Further instructions in QA Book
  • Conduct a recording test to Metacog, further instructions in the QA Book. Do this for iPadOS + Safari and one other
    random platform.
  • Conduct a memory test on the stand alone sim wrapper (rc.1).
  • Test one platform combination with ?phetioDebug=true on the Studio and State wrapper.
  • If Pan/Zoom is supported, make sure that it works when set with PhET-iO State.
  • Test that the sim works offline:
    • Click the link to the phet-io zip file (at top of issue) to download the zip file.
    • Unzip it to a spot locally.
    • Open index.html by double clicking it on your desktop or in a Finder-view.
    • It should look like the standalone version of the sim in PhET-iO brand.

Accessibility features

What to Test

  • Specific instructions can be found above.

  • Make sure the accessibility (a11y) feature that is being tested doesn't negatively affect the sim in any way. Here is
    a list of features that may be supported in this test:

    • Alternative Input
    • Interactive Description
    • Sound and Sonification
    • Pan and Zoom
    • Mobile Description
    • Voicing
  • Test all possible forms of input.

    • Test all mouse/trackpad inputs.
    • Test all touchscreen inputs.
    • Test all keyboard navigation inputs (if applicable).
    • Test all forms of input with a screen reader (if applicable).
  • If this sim is not in this list or up to date there, make an
    issue in website to ask if PhET research page links need updating. Please
    assign to @terracoda and @emily-phet.

Screen Readers

This sim may support screen readers. If you are unfamiliar with screen readers, please ask Katie to introduce you to
screen readers. If you simply need a refresher on screen readers, please consult the
QA Book, which should have all of the information
you need as well as a link to a screen reader tutorial made by Jesse. Otherwise, look over the a11y view before opening
the simulation. Once you've done that, open the simulation and make sure alerts and descriptions work as intended.

Platforms and Screen Readers to Be Tested

  • Windows 10 + Latest Chrome + Latest JAWS
  • Windows 10 + Latest Firefox + Latest NVDA
  • macOS + Safari + VoiceOver
  • iOS + Safari + VoiceOver (only if specified in testing issue)

Critical Screen Reader Information

We are tracking known screen reader bugs in
here. If you find a
screen reader bug, please check it against this list.

Keyboard Navigation

This sim supports keyboard navigation. Please make sure it works as intended on all platforms by itself and with a
screen reader.

Magnification

This sim supports magnification with pinch and drag gestures on touch screens, keyboard shortcuts, and mouse/wheel controls. Please test magnfication and make sure
it is working as intended and well with the use cases of the simulation. Due to the way screen readers handle user input, magnification is NOT expected to
work while using a screen reader so there is no need to test this case.


FAQs for QA Members
There are multiple tests in this issue... Which test should I do first?

Test in order! Test the first thing first, the second thing second, and so on.


How should I format my issue?

Here's a template for making issues:

  <b>Test Device</b>

  blah

  <b>Operating System</b>

  blah

  <b>Browser</b>

  blah

  <b>Problem Description</b>

  blah

  <b>Steps to Reproduce</b>

  blah

  <b>Visuals</b>

  blah

  <details>
  <summary><b>Troubleshooting Information</b></summary>

  blah

  </details>

Who should I assign?

We typically assign the developer who opened the issue in the QA repository.


My question isn't in here... What should I do?

You should:

  1. Consult the QA Book.
  2. Google it.
  3. Ask Katie.
  4. Ask a developer.
  5. Google it again.
  6. Cry.


@KatieWoe
Copy link
Contributor

Memory test:
frictionmem
PhET-iO Memory test:
frictionmemio

@KatieWoe
Copy link
Contributor

There's no migration supported in this version, but the instructions are still in the guide. Is this a bug?

@zepumph
Copy link
Member Author

zepumph commented Jan 25, 2023

By "the guide" do you mean the PhET-iO Guide link? https://phet-dev.colorado.edu/html/friction/1.6.0-rc.1/phet-io/doc/guides/phet-io-guide.html

This is expected, as that guide is general for all simulations. It doesn't pick and choose based on the features of that specific simulation. Thanks for asking.

@Nancy-Salpepi
Copy link
Contributor

@zepumph Noting that phetsims/joist#898 is present in this RC but is fixed in master.

@zepumph
Copy link
Member Author

zepumph commented Jan 25, 2023

@zepumph Noting that phetsims/joist#898 is present in this RC but is fixed in master.

Thanks. That is very helpful. I made phetsims/friction#327 to make sure the cherry picks will happen into friction.

@KatieWoe
Copy link
Contributor

KatieWoe commented Feb 3, 2023

The extra sound is not stateful. I believe this is intended, but it does seem odd so I wanted to bring it up just in case.

@samreid
Copy link
Member

samreid commented Feb 3, 2023

Do you mean whether the "extra sound" checkbox is checked? Specific user preferences are not intended to be saved and loaded. There are a few exceptions, but extra sound is not one of them.

@KatieWoe
Copy link
Contributor

KatieWoe commented Feb 3, 2023

Yes, that is what I meant. Most other preferences I've seen in PhET-iO so far have been stateful, so I found it odd.

@arouinfar
Copy link
Contributor

Under the Preferences Customization section of the PhET-iO Guide we state:

Some preference selections are saved into the simulation state, and persist in the save and launch process of the Standard PhET-iO Wrapper. These include audioEnabledProperty, colorProfileProperty, and all settings on the Simulation tab.

@KatieWoe if you are finding the behavior is at odds with this, please let us know.

@KatieWoe
Copy link
Contributor

KatieWoe commented Feb 3, 2023

No, it's behaving correctly. I just find the correct behavior odd.

@KatieWoe
Copy link
Contributor

KatieWoe commented Feb 3, 2023

Actually, never mind. I think I do see something.

@KatieWoe
Copy link
Contributor

KatieWoe commented Feb 3, 2023

Calling QA here
Jaron Droder, Nancy Salpepi, and Emily Miller should be added to the credits.

@jessegreenberg
Copy link
Contributor

Wonderful. Thanks so much for your work on this one QA team, it was a beast.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests

7 participants