-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sound fluctuates after turning off Voicing on iPad #423
Comments
It also fluctuates when Voicing is on and nothing is being read. |
Thanks @Nancy-Salpepi - Just in case, I tried on Win 10 Chrome but did not see it there so Ill try on iOS. This is probably a common code problem with audio ducking + speech synthesis (phetsims/tambo#167) |
I am able to reproduce this with iOS 15.0.2 Safari. I could not reproduce this in macOS 11.7.2 Safari. |
|
I found it. It is caused by this workaround that was added for Chromebooks: https://github.com/phetsims/utterance-queue/blob/36fdea460883369af36712e1aefef89bf2e25e0d/js/SpeechSynthesisAnnouncer.ts#L472-L483 What must be happening is that iOS has built-in audio ducking for speech synthesis. That is why removing PhET's audio ducking didn't change the behavior. The empty string in that workaround still triggers the ducking even though there is no speech. I am guessing this was also introduced when the workaround string became an empty space for phetsims/friction#328. |
I just noticed that this is a problem for all iOS browsers, not just Safari. So if we opt out of that workaround we need it to be for all iOS which we don't currently have a check for in platform.js. |
A fix has been proposed in phetsims/utterance-queue#110. @Nancy-Salpepi can you please test again and confirm this is fixed? |
The sound sounds fixed in master. haha 🙃 |
Excellent, thanks! |
Test device
iPad 9th generation
Operating System
iOS 16.3.1
Browser
safari
Problem description
For phetsims/qa#923, after turning off Voicing the Shape Sounds will fade in and out.
Steps to reproduce
Visuals
Here is what is sounds like after the steps above:
SoundFlux.mov
The text was updated successfully, but these errors were encountered: