Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release new version for phet and phet-io brand #88

Closed
zepumph opened this issue Jun 26, 2017 · 29 comments
Closed

Release new version for phet and phet-io brand #88

zepumph opened this issue Jun 26, 2017 · 29 comments
Assignees

Comments

@zepumph
Copy link
Member

zepumph commented Jun 26, 2017

from phetsims/qa#4 (comment), it would be good to do a dev release first. I will do one for phet-io, and then create RC's for the phet and phet-io versions.

I should do these first:

@zepumph
Copy link
Member Author

zepumph commented Jul 3, 2017

After talking with @ariel-phet, we think the best approach to get both a phet-io and phet brand published is to do the following three qa tests:

  1. phet brand dev release
  2. phet brand rc
  3. phet-io rc

zepumph added a commit that referenced this issue Jul 3, 2017
@zepumph
Copy link
Member Author

zepumph commented Jul 3, 2017

Alright the dev version is ready

@zepumph zepumph changed the title Create a dev release of phet-io features in RIAW Release new version for phet and phet-io brand Jul 3, 2017
@zepumph
Copy link
Member Author

zepumph commented Jul 3, 2017

phetsims/qa#16

@zepumph
Copy link
Member Author

zepumph commented Jul 5, 2017

Make sure to update credits before publishing

@zepumph
Copy link
Member Author

zepumph commented Jul 11, 2017

@zepumph
Copy link
Member Author

zepumph commented Jul 18, 2017

I made some substantial changes in #91, and I will do another dev test before going to RC.

zepumph added a commit that referenced this issue Aug 1, 2017
@zepumph
Copy link
Member Author

zepumph commented Aug 2, 2017

phet-io dev test: phetsims/qa#32

@phet-steele
Copy link
Contributor

@zepumph don't forget #96 either!

@jessegreenberg
Copy link
Contributor

@zepumph what is the status of this issue? We are ready to deploy a PhET brand RC of this sim with keyboard navigation, should we coordinate?

@zepumph
Copy link
Member Author

zepumph commented Sep 28, 2017

I think there is just phetsims/ohms-law#68 (which effects RIAW as well). I would love some help on it, I think it has to do with some layout changes I did earlier in the summer, but I can't track down the problem.

@jessegreenberg
Copy link
Contributor

Ok, thanks @zepumph. Does that need to be fixed before a redeploy? Does the currently deployed version have that issue as well?

@zepumph
Copy link
Member Author

zepumph commented Sep 28, 2017

I don't think it is in the latest version on phet. I'll take another look at it and see what I can do.

@zepumph
Copy link
Member Author

zepumph commented Sep 28, 2017

phetsims/ohms-law#68 is fixed, and we are ready for a release. I'm not sure if we should do a PhET-iO version now, since there seems to be no request for it. @samreid do you think we should release RIAW for phet-io right now too?

@samreid
Copy link
Member

samreid commented Sep 28, 2017

It is up to @kathy-phet.

@samreid
Copy link
Member

samreid commented Sep 28, 2017

On second thought, If the sim is improved, it seems we should also test and publish the phet-io one too.

@zepumph
Copy link
Member Author

zepumph commented Sep 28, 2017

@samreid how stable do you think master is right now due to https://github.com/phetsims/phet-io/issues/1223. Should we worry?

@samreid
Copy link
Member

samreid commented Sep 28, 2017

It still needs attention and should be considered unstable. You could grab an estimate earlier sha or wait unit it is resolved

@zepumph
Copy link
Member Author

zepumph commented Sep 28, 2017

I think that resolution sounds like a good idea. I will crank away at some of them, and try to get it more stable so we can figure out if that's the way we want to go definitively.

@zepumph
Copy link
Member Author

zepumph commented Oct 10, 2017

@jessegreenberg think that master is more stable now for an RC

@jessegreenberg
Copy link
Contributor

Thanks @zepumph!

@jessegreenberg
Copy link
Contributor

A phetio rc was deployed for testing here:
phetsims/qa#53

Once it passes testing, phet branded version will use the same SHAs.

@zepumph
Copy link
Member Author

zepumph commented Oct 17, 2017

Unassigning, let me know how I can help.

@zepumph zepumph removed their assignment Oct 17, 2017
@jessegreenberg
Copy link
Contributor

@zepumph in #107 we decided not to include keyboard nav in phet-io releases until a11y features work with PhET-iO. So the current plan is to deploy 1.3-phetio without keyboard nav and then a 1.4 PhET brand version with keyboard nav. Does that sound correct?

@zepumph
Copy link
Member Author

zepumph commented Oct 18, 2017

That sounds like our current plan, although it is kinda a pain in the butt. I want to double check with @samreid. Sam does this seem right to you?

@samreid
Copy link
Member

samreid commented Oct 18, 2017

Perhaps we should defer further phet-io releases until we get Faraday's Law stabilized and have PhET-iO design meetings for each sim?

@zepumph
Copy link
Member Author

zepumph commented Oct 18, 2017

That would be a question for @kathy-phet, using the old way of instrumenting. OL and RIAW are both ready for phet-io releases. The question is should we spend the QA time to do this if we will just need to republish a "stable" version soon.

@zepumph
Copy link
Member Author

zepumph commented Oct 18, 2017

@kathy-phet should we proceed with RIAW phet-io release even though it has not had design time to move it to a "stable api?"

@samreid samreid removed their assignment Oct 21, 2017
@zepumph
Copy link
Member Author

zepumph commented Nov 11, 2017

@zepumph
Copy link
Member Author

zepumph commented Nov 11, 2017

@jessegreenberg you are taking on the phet version in a different issue and a different version (since it has accessibility enabled by default). Closing.

@zepumph zepumph closed this as completed Nov 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants