Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change copy English value icon? #334

Closed
Tracked by #878 ...
liammulh opened this issue Dec 20, 2022 · 3 comments
Closed
Tracked by #878 ...

Change copy English value icon? #334

liammulh opened this issue Dec 20, 2022 · 3 comments

Comments

@liammulh
Copy link
Member

@oliver-phet, @DianaTavares, what do you think a better icon would be for the copy English value icon? I am using https://icons.getbootstrap.com/.

In the test for Rosetta 2.0 (phetsims/qa#869), @DianaTavares noted that it would be helpful to have a button to copy the English value to the clipboard so that it could be easily pasted into Google Translate.

I think this could be done with the Clipboard API easily enough. And we could add this feature in a future release.

However, the current button has an icon that looks a lot like a button for copying to the clipboard:

image

We should probably change this icon before Rosetta 2.0 is released to avoid confusion with a future copy to clipboard button.

@DianaTavares
Copy link

I like the two pages icon for copy in the clipboard. What about an arrow to represent passing the English string to the translation side?
image

image

@oliver-phet
Copy link
Contributor

Sure, probably not a bad call to better distinguish this behavior from 'copy to clipboard'.
I actually like box-arrow-in-right because I think it better implies inserting something in the box (the English string).

I'd like to defer any copy to clipboard until after 2.0, though. I remember @kathy-phet had some reservations around allowing translators to copy the value of English strings.

@Nancy-Salpepi
Copy link

In round 2: copy button has been changed to box-arrow-in-right.

Closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants