Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we add a "Total" column to the translation report? #348

Closed
Tracked by #878 ...
jbphet opened this issue Dec 23, 2022 · 5 comments
Closed
Tracked by #878 ...

Should we add a "Total" column to the translation report? #348

jbphet opened this issue Dec 23, 2022 · 5 comments

Comments

@jbphet
Copy link
Contributor

jbphet commented Dec 23, 2022

As of this writing, the columns for the translation report look like this:

image

This makes it a little hard for users to answer questions like "What sims need the least work to finish up?" or "Which sims need the most work?". Should we consider adding a "Total" column to make this easier? My guess is that they would use that column for sorting more than the others.

@oliver-phet
Copy link
Contributor

This sounds like more of a 2.1 feature. I'd recommend focusing on #332 (comment)
(sorting using the entire string - so that sims with the same % and sorted).

@jbphet
Copy link
Contributor Author

jbphet commented Dec 23, 2022

There is another issue that is also about adding a column, and we should consider that one when evaluating this one, since we don't want to make the report look too cluttered. See #347.

@oliver-phet
Copy link
Contributor

Discussed with @liammulh today. We decided it would be best to move to a single column "Strings Translated" that is a composite of sim-specific, shared, and common strings. Updated design:
image

@oliver-phet oliver-phet assigned liammulh and unassigned oliver-phet Dec 23, 2022
liammulh added a commit that referenced this issue Dec 23, 2022
This change came out a discussion I had with Oliver Nix regarding
condesning translation statistics in the translation report. The issues
we were discussing were #347
and #348.
liammulh added a commit that referenced this issue Jan 4, 2023
liammulh added a commit that referenced this issue Jan 4, 2023
liammulh added a commit that referenced this issue Jan 4, 2023
liammulh added a commit that referenced this issue Jan 4, 2023
@liammulh
Copy link
Member

liammulh commented Jan 4, 2023

I think as of 48bb47a, the total column is working as envisioned in this issue. I will mark this as ready to review.

@Nancy-Salpepi
Copy link

Things looks good in round 2--there is now only one column: Translated Strings. The associated sort button is working as it should. Next to each percentage there is now an info button which separates out the strings by type.

Closing.

liammulh added a commit that referenced this issue Feb 8, 2023
This change came out a discussion I had with Oliver Nix regarding
condesning translation statistics in the translation report. The issues
we were discussing were #347
and #348.
liammulh added a commit that referenced this issue Feb 8, 2023
liammulh added a commit that referenced this issue Feb 8, 2023
liammulh added a commit that referenced this issue Feb 8, 2023
liammulh added a commit that referenced this issue Feb 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants