Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Grab/Drag grabbableOptions.appendDescription: true by default #550

Closed
zepumph opened this issue Nov 4, 2019 · 2 comments
Closed

Grab/Drag grabbableOptions.appendDescription: true by default #550

zepumph opened this issue Nov 4, 2019 · 2 comments
Assignees
@jessegreenberg
Labels
status:ready-for-review

Comments

@zepumph
Copy link
Member

zepumph commented Nov 4, 2019

While working on #536, it looks like every help text given to a grab/drag interaction wants to be appended, so I'll make that the default.
zepumph added a commit to phetsims/balloons-and-static-electricity that referenced this issue Nov 4, 2019
@zepumph
appendDescription true by default, phetsims/scenery-phet#550
d79a6a0
zepumph added a commit to phetsims/inverse-square-law-common that referenced this issue Nov 4, 2019
@zepumph
appendDescription true by default, phetsims/scenery-phet#550
6d38643
zepumph added a commit that referenced this issue Nov 4, 2019
@zepumph
appendDescription true by default, #550
bfa86d2
zepumph added a commit to phetsims/friction that referenced this issue Nov 4, 2019
@zepumph
appendDescription true by default, phetsims/scenery-phet#550
da568b0
@zepumph
Copy link
Member Author

zepumph commented Nov 4, 2019

@jessegreenberg please review the addition of this default.

@zepumph zepumph assigned jessegreenberg and unassigned zepumph Nov 4, 2019
@jessegreenberg
Copy link
Contributor

Yep, this is a better default, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jessegreenberg jessegreenberg

Labels
status:ready-for-review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jessegreenberg @zepumph