Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabled components should be pickable #239

Closed
jessegreenberg opened this issue Jul 7, 2016 · 3 comments
Closed

Disabled components should be pickable #239

jessegreenberg opened this issue Jul 7, 2016 · 3 comments
Assignees

Comments

@jessegreenberg
Copy link
Contributor

It has been part of the code review checklist to make sure that user interface components with enabled:false also have pickable:false. For accessibility, we need disabled components to be pickable so that they can still be discovered with the mouse or finger.

We will need to go through interface components and make sure that elements have pickable:true while disabled. If we set pickable to true for any component, we should verify that nothing has been broken and that performance was not negatively impacted in sims which use the changed element.

@jessegreenberg jessegreenberg self-assigned this Jul 7, 2016
@jessegreenberg
Copy link
Contributor Author

This issue is dependent on phetsims/scenery#41. If we can get the accessible DOM to handle discoverability, pickability is no longer an issue for accessibility.

@pixelzoom
Copy link
Contributor

Disabled components should now be using scenery's new inputEnabled option instead of pickable. It will take some time to update all UI components that are currently using pickable, but see #257.

@jessegreenberg Can we close this issue?

@jessegreenberg
Copy link
Contributor Author

Yes, this issue can be closed now. We will have to follow through with phetsims/scenery#41 for discoverability.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants