Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address TODO about propagating options to button model. #749

Open
pixelzoom opened this issue Apr 8, 2022 · 0 comments
Open

Address TODO about propagating options to button model. #749

pixelzoom opened this issue Apr 8, 2022 · 0 comments

Comments

@pixelzoom
Copy link
Contributor

This NOTE was added by @jonathanolson when he converted RectangularPushButton to TypeScript. It should have been a TODO, with an issue. The same problem needs to be addressed in RoundPushButton, and any other sun button that propagates all of its options to its model class. It's unlikely that there's a TODO in every location where this needs to be addressed.

// NOTE: Let's not create PushButtonModel with these options?
export type RectangularPushButtonOptions = SelfOptions & RectangularButtonOptions & PushButtonModelOptions;
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants